Failure during consistency group deletion with gpfs driver

[David Rosales]

There is an issue with the gpfs driver when trying to force delete a consistency group. The below error occurs

2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 3219, in delete_group
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server self.db.volumes_update(context, volumes_model_update)
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/db/api.py", line 323, in volumes_update
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server return IMPL.volumes_update(context, values_list)
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 251, in wrapper
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server return f(*args, **kwargs)
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 196, in wrapper
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server return f(*args, **kwargs)
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 2448, in volumes_update
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server return f(*args, **kwargs)
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server File "/usr/lib/python2.7/site-packages/cinder/db/sqlalchemy/api.py", line 2448, in volumes_update
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server values.pop('id')
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server AttributeError: 'Volume' object has no attribute 'pop'
2017-04-12 07:33:27.171 45940 ERROR oslo_messaging.rpc.server

The cinder volume manager expects a list of dictionaries to use for updating the volumes. When the gpfs driver is called, it is handed a list of Volume objects to work with. Instead of translating the changes to a list of dicts, it returns the Volume object list and is hitting the above error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464179

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464179
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b812f1269b5ee8a7f2b2825bc4937872f2c0e411
Submitter: Jenkins
Branch: master

commit b812f1269b5ee8a7f2b2825bc4937872f2c0e411
Author: digvijay2016 <email address hidden>
Date: Fri May 12 16:17:01 2017 +0530

    Fix forceful deletion of Consistency Group for GPFS Driver

    For a operation of deleting consistency group when it contain
    one or more volumes, GPFS driver is currently returning a list
    of Volume objects to cinder volume manager which is expecting
    a list of dictionaries to use for updating the volumes.

    With this patch, GPFS will be able to delete consistency group
    forcefully too.

    Change-Id: Ie56c443a2a07c86001cbb9269058aaa0ccca6e84
    Closes-bug: #1685355

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/465923

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465923
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=343c251fcdc71de648e69485d0417b70b8b3d8ae
Submitter: Jenkins
Branch: stable/ocata

commit 343c251fcdc71de648e69485d0417b70b8b3d8ae
Author: digvijay2016 <email address hidden>
Date: Fri May 12 16:17:01 2017 +0530

    Fix forceful deletion of Consistency Group for GPFS Driver

    For a operation of deleting consistency group when it contain
    one or more volumes, GPFS driver is currently returning a list
    of Volume objects to cinder volume manager which is expecting
    a list of dictionaries to use for updating the volumes.

    With this patch, GPFS will be able to delete consistency group
    forcefully too.

    Change-Id: Ie56c443a2a07c86001cbb9269058aaa0ccca6e84
    Closes-bug: #1685355
    (cherry picked from commit b812f1269b5ee8a7f2b2825bc4937872f2c0e411)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.3 release.