LIO: AttributeError on terminate_connection

[Eric Harney]

I hit this error while testing "cinder upload-to-image" in a situation where Glance fails.

terminate_connection() is called but no "provider_location" exists.

2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager Traceback (most recent call last):
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 1537, in terminate_connection
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager force=force)
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager File "/usr/lib/python2.7/site-packages/cinder/volume/drivers/lvm.py", line 848, in terminate_connection
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager **kwargs)
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager File "/usr/lib/python2.7/site-packages/cinder/volume/targets/lio.py", line 190, in terminate_connection
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager volume_iqn = volume['provider_location'].split(' ')[1]
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager AttributeError: 'NoneType' object has no attribute 'split'
2017-04-19 13:51:39.120 14272 ERROR cinder.volume.manager

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/458192

[Ian Wienand (iwienand)]

I hit the same thing in Bug #1686594 , although in the context of using lio+centos in devstack, where this caused failure of the test_force_detach_volume fails test

[Gorka Eguileor (gorka)]

This is now holding the OS-Brick gate, as gate-tempest-dsvm-full-lio-src-os-brick-ubuntu-xenial is constantly failing [1][2] due to this error [3].

[1] https://review.openstack.org/424747
[2] https://review.openstack.org/433666
[3] http://logs.openstack.org/47/424747/4/check/gate-tempest-dsvm-full-lio-src-os-brick-ubuntu-xenial/e7c1a73/logs/screen-c-vol.txt.gz#_May_11_08_14_46_531368

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/458192
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3e37cb6f8cf489480e264b434290064a61c4a782
Submitter: Jenkins
Branch: master

commit 3e37cb6f8cf489480e264b434290064a61c4a782
Author: Eric Harney <email address hidden>
Date: Wed Apr 19 14:00:51 2017 -0400

    LIO: Fix terminate_connection AttributeError

    "provider_location" is not guaranteed to contain
    a value here.

    Closes-Bug: #1684243

    Change-Id: I964917d13d9415223845ac17eb804ee7faceaf6f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/466800

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466800
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0abb6662b811e8d677737db2fdbccb30b483ee5b
Submitter: Jenkins
Branch: stable/ocata

commit 0abb6662b811e8d677737db2fdbccb30b483ee5b
Author: Eric Harney <email address hidden>
Date: Wed Apr 19 14:00:51 2017 -0400

    LIO: Fix terminate_connection AttributeError

    "provider_location" is not guaranteed to contain
    a value here.

    Closes-Bug: #1684243

    Change-Id: I964917d13d9415223845ac17eb804ee7faceaf6f
    (cherry picked from commit 3e37cb6f8cf489480e264b434290064a61c4a782)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.3 release.