Incorrect exception handling when deletion encryption keys

Bug #1681874 reported by Eric Harney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Eric Harney

Bug Description

When deleting a volume, the volume encryption key is deleted from the key manager. If this fails, the log message tries to print the "msg" field from the exception. For CinderExceptions, this works. For other types of exceptions, this field does not exist.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/455749

Changed in cinder:
assignee: nobody → Eric Harney (eharney)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/455749
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6e2d8fd0664d468228d78ceea0e96e10d560be6a
Submitter: Jenkins
Branch: master

commit 6e2d8fd0664d468228d78ceea0e96e10d560be6a
Author: Eric Harney <email address hidden>
Date: Tue Apr 11 11:25:09 2017 -0400

    Fix encryption key deletion error handling on volume delete

    e.msg is only present for CinderExceptions, not all exception
    types.

    Closes-Bug: #1681874

    Change-Id: I02601ae2a9ba95ab7145b86e24a094272f4cfbf6

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Kaitlin Farr (kaitlin-farr) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/463861

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/ocata)

Reviewed: https://review.openstack.org/463861
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8a090e5510792d5989e9215ecb0c9cf7a3ac849c
Submitter: Jenkins
Branch: stable/ocata

commit 8a090e5510792d5989e9215ecb0c9cf7a3ac849c
Author: Eric Harney <email address hidden>
Date: Tue Apr 11 11:25:09 2017 -0400

    Fix encryption key deletion error handling on volume delete

    e.msg is only present for CinderExceptions, not all exception
    types.

    Closes-Bug: #1681874

    Change-Id: I02601ae2a9ba95ab7145b86e24a094272f4cfbf6
    (cherry picked from commit 6e2d8fd0664d468228d78ceea0e96e10d560be6a)
    Conflicts:
     cinder/volume/api.py

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.0.0b2

This issue was fixed in the openstack/cinder 11.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.3

This issue was fixed in the openstack/cinder 10.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.