Improve test_volume_backup_create_get_detailed_list_restore_delete

Bug #1680852 reported by Jon Bernard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
New
Undecided
Unassigned
tempest
Opinion
Undecided
Unassigned

Bug Description

This test 'test_volume_backup_create_get_detailed_list_restore_delete' was recently changed [1] to pass a non-default container parameter to create_backup(). For the Ceph backend, this functionality is not supported and a quick fix [2] was proposed to skip the entire test for Ceph. By skipping the entire test, we do loose some test coverage for the ceph backend for the case there the default container is used. A finer-grained approach is preferable where either the test is broken into separate pieces or the container= and its assert() are conditionally skipped for backends which do not support it.

[1] https://review.openstack.org/#/c/453140/
[2] https://review.openstack.org/#/c/454321/

Jon Bernard (jbernard)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/454722

Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tempest (master)

Change abandoned by Andrea Frittoli (<email address hidden>) on branch: master
Review: https://review.openstack.org/454722

Revision history for this message
Ken'ichi Ohmichi (oomichi) wrote :

I feel this bug report says Cinder abstraction API layer doesn't work for Ceph backend at the place.
So it would be great to get feedback from Cinder team.

Changed in tempest:
status: In Progress → Opinion
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

I think it may make more sense to update the backup drivers to handle this rather than changing the test. It would be better if the driver is robust enough to handle or skip input that is not relevant for it. So the API and usage is the same, but some of the internal behavior is dependent on the configured backup driver.

Revision history for this message
wangxiyuan (wangxiyuan) wrote :

Is there any way to create a new ceph pool by Cinder?

Revision history for this message
Jon Bernard (jbernard) wrote :

This is precisely why I disabled the test for ceph - it can never adhere to this API. Pools cannot be created dynamically in this way, the API was created with Swift in mind and there are certain features that we cannot mimic. We can either not run the test, or accept the request and perform the standard logic that we would otherwise while ignoring the container name - this seems misleading at best.

Revision history for this message
wangxiyuan (wangxiyuan) wrote :

Yeah, the truth is that ceph can't create pool dynamically here. So in Cinder side, for some backends like ceph, it's better to ignore the "container" parameter autolly by code logic IMO.

Changed in cinder:
assignee: nobody → wangxiyuan (wangxiyuan)
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote : Bug Assignee Expired

Unassigning due to no activity for > 6 months.

Changed in cinder:
assignee: wangxiyuan (wangxiyuan) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.