create backup from in-use volume destroy quota value

[int32bit]

Currently if we create a backup from a in-use volume, we will create a temp volume first, this volume is created directly from DB, and skip quota compute[1]:

[1] https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L1430-L1459

But when we finish creating backup and to cleanup temp volume, we call volume-api to delete temp volume and will release its quota we don't compute before[2]

[2] https://github.com/openstack/cinder/blob/master/cinder/backup/manager.py#L304-L315

As result, creating hot-backup will reduce user's volume in-use quota value.

[int32bit (int32bit)]

IMO, we need commit quota before create temp volume to keep quota consistence.

[int32bit (int32bit)]

But even if user's volume quota is full, we should allow user to create backup, so user's volume quota may be larger than max limit before cleanup temp volume.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/535167

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/535167
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c755e29126dc990f000097064937c5d9676cb3cc
Submitter: Zuul
Branch: master

commit c755e29126dc990f000097064937c5d9676cb3cc
Author: lihaijing <email address hidden>
Date: Thu Jan 18 13:14:45 2018 +0800

    Fix cinder quota-usage error

    When backing up a snapshot or 'in-use' volume,
    cinder creates a temp volume from the snapshot
    or 'in-use' volume, then backup the temp volume.
    The temp volume doesn't use the volume-quota,
    but deleting the temp volume when finishing
    backup will minus quota. This process leads to
    a wrong quota-usage. So add admin volume metadata
    when creating the temporary volume and then use
    that data to detect temporary volume. Then skip
    handling quota when deleting the temp volume.

    Change-Id: If100a678cf9062c4078f850d8edc001b6b0705f4
    Closes-Bug: #1670636

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/579691

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/579691
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f8212217e9ebc16876e5dda815cc7db0900ff83b
Submitter: Zuul
Branch: stable/pike

commit f8212217e9ebc16876e5dda815cc7db0900ff83b
Author: lihaijing <email address hidden>
Date: Thu Jan 18 13:14:45 2018 +0800

    Fix cinder quota-usage error

    When backing up a snapshot or 'in-use' volume,
    cinder creates a temp volume from the snapshot
    or 'in-use' volume, then backup the temp volume.
    The temp volume doesn't use the volume-quota,
    but deleting the temp volume when finishing
    backup will minus quota. This process leads to
    a wrong quota-usage. So add admin volume metadata
    when creating the temporary volume and then use
    that data to detect temporary volume. Then skip
    handling quota when deleting the temp volume.

    Change-Id: If100a678cf9062c4078f850d8edc001b6b0705f4
    Closes-Bug: #1670636
    (cherry picked from commit c755e29126dc990f000097064937c5d9676cb3cc)
    Conflicts:
     cinder/tests/unit/utils.py

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.2.0 release.