Misleading error during image clone when copyoffload tool is not present

[Marc Koderer]

The copyoffload tool is optional and should not cause "error" messages when not present.

The following error is shown during image clone:

2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode [req-f9e2642d-4e2a-423f-a67f-c8ff8c3cda4e - - - - -] Error in workflow copy from cache. [Errno 2] No such file or directory.
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode Traceback (most recent call last):
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py", line 467, in _copy_from_cache
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode self._copy_from_remote_cache(volume, image_id, cache_copy)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/cinder/utils.py", line 872, in trace_method_logging_wrapper
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode return f(*args, **kwargs)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/cinder/utils.py", line 872, in trace_method_logging_wrapper
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode return f(*args, **kwargs)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/cinder/volume/drivers/netapp/dataontap/nfs_cmode.py", line 514, in _copy_from_remote_cache
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode run_as_root=False, check_exit_code=0)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/cinder/utils.py", line 155, in execute
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode return processutils.execute(*cmd, **kwargs)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/oslo_concurrency/processutils.py", line 249, in execute
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode env=env_variables)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib/python2.7/site-packages/eventlet/green/subprocess.py", line 53, in __init__
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode subprocess_orig.Popen.__init__(self, args, 0, *argss, **kwds)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib64/python2.7/subprocess.py", line 710, in __init__
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode errread, errwrite)
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode File "/usr/lib64/python2.7/subprocess.py", line 1335, in _execute_child
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode raise child_exception
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode OSError: [Errno 2] No such file or directory
2017-02-01 09:16:45.141 12942 ERROR cinder.volume.drivers.netapp.dataontap.nfs_cmode

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/427613

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/427613
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5043f56cb65defd5f623881584681ae814da1a4e
Submitter: Jenkins
Branch: master

commit 5043f56cb65defd5f623881584681ae814da1a4e
Author: Marc Koderer <email address hidden>
Date: Wed Feb 1 10:49:35 2017 +0100

    NetApp cDOT: Add check if copyoffload tool is available

    The copyoffload tool is optional and not always in place. This fixes a
    misleading error message during image clone creation when the tool is
    not in place.

    Change-Id: I66f28faaac629fbfa7ec57fa5238451eb7c6820a
    Closes-bug: #1660927

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0b1 development milestone.