test_emc_vmax.py should not mock volume_types.get_volume_type_extra_spec globally

[jiamin]

in test_emc_vmax.py, EMCV3MultiPoolDriverTestCase mocks volume_types.get_volume_type_extra_specs globally, if other drivers use it and run after it, they will have problem.

6913 volume_types.get_volume_type_extra_specs = mock.Mock(
6914 return_value={'volume_backend_name': 'MULTI_POOL_BE',
6915 'pool_name': 'Bronze+DSS+SRP_1+1234567891011'})

[Xing Yang (xing-yang)]

Please replace the following mock decorator for volume_types with "with mock.patch.object" inside the test to limit the scope:

    @mock.patch.object(
        volume_types,
        'get_volume_type_extra_specs',
        return_value={'volume_backend_name': 'MULTI_POOL_BE'})
    def test_delete_CG_no_volumes_multi_pool_success(

Please do a search and fix all the mocks for volume_types.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/425803

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/425803
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d063ed99e591f8a81261c0f80125b98d9a94d19f
Submitter: Jenkins
Branch: master

commit d063ed99e591f8a81261c0f80125b98d9a94d19f
Author: Helen Walsh <email address hidden>
Date: Thu Jan 26 17:35:32 2017 +0000

    VMAX driver - remove global mock of volume_types

    Some test classes mock volume_types.get_volume_type_extra_specs
    globally, if other drivers use it and run after it, they will
    have problems.

    Change-Id: Ie25c35e8c04457a09f95230185586703b1fce83f
    Closes-Bug: #1659481

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.0.0rc1 release candidate.