Huawei driver encode_name uses unstable hash() for ids
Bug #1658725 reported by
Eric Harney
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Undecided
|
Yingzhe Zeng |
Bug Description
encode_name() in huawei_utils.py uses hash() to generate "stable" identifiers for volumes, snapshots, etc.
This is not a safe thing to do, hash() generates different values for different instances of python.
Unit tests only pass because we fix PYTHONHASHSEED=0 in tox.ini. And the tests already have an odd workaround to make this pass on py27 and py3*, which return different values.
This needs to be reworked.
tags: | added: drivers huawei |
Changed in cinder: | |
status: | New → Confirmed |
Changed in cinder: | |
assignee: | nobody → TommyLike (hu-husheng) |
Changed in cinder: | |
assignee: | TommyLike (hu-husheng) → Yingzhe Zeng (zengyingzhe) |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/465789
Review: https:/