volume status was wrong when run reset-state CLI

[xianming mao]

When we live-migrate a volume failed, the volume status was in-use and migrate status was error. We only want to clear the migrate status through run following CLI:
     cinder reset-state [--reset-migration-status] <volume> [<volume> ...]
But after that, not only clear the migrate status but also change volume status into 'available' even though it was attached on a server, this isn't what we expected, so I report this bug to repair it.

As following shown, this volume actually status is 'in-use', because it has attached on a server before we run following CLI:
cinder reset-state [--reset-migration-status] <volume>
but after this CLI completed ,the volume status was changed into 'available', it's not TRUE, because this volume is not detach from a server untill now!

+---------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Property | Value |
+---------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| attachments | [{u'server_id': u'25e82035-9238-4413-8791-6add0455ab3d', u'attachment_id': u'0f415605-9be2-4b06-8b31-ab3170503bc9', u'host_name': None, u'volume_id': u'91cc6b0b-2bc8-437c-bca4-b654de620d47', u'device': u'/dev/vdb', u'id': u'91cc6b0b-2bc8-437c-bca4-b654de620d47'}] |
| availability_zone | nova |
| bootable | false |
| consistencygroup_id | None |
| created_at | 2017-01-16T09:11:49.000000 |
| description | None |
| encrypted | False |
| id | 91cc6b0b-2bc8-437c-bca4-b654de620d47 |
| metadata | {u'readonly': u'False', u'attached_mode': u'rw'} |
| migration_status | None |
| multiattach | False |
| name | vol |
| os-vol-host-attr:host | node-2@lvm#lvm |
| os-vol-mig-status-attr:migstat | None |
| os-vol-mig-status-attr:name_id | None |
| os-vol-tenant-attr:tenant_id | 813cb32a89d540199e412dfcc1319576 |
| os-volume-replication:driver_data | None |
| os-volume-replication:extended_status | None |
| replication_status | disabled |
| size | 1 |
| snapshot_id | None |
| source_volid | None |
| status | available |
| user_id | 0af9a7fb75934600a1d24185eb8acda6 |
| volume_type | lvm |
+---------------------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/421775

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/421775
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.