Error thrown for create volume from CG snapshot

[Vinita Deshpande]

Currently, in created_cloned_volume() (invoked from create_volume_from_snapshot) , when you create a volume from a snapshot, we need to check if that snapshot is part of a Consistency group, our current implementation only checks if a Volume is part of a consistency group (create_cloned_volume() is used by multiple functions).

For a VMAX Snapshot, we need not check if the size of snapshot is greater than the size of the source volume because for Snapshot we cannot specify a size.

We also need to use the correct exception type to handle meta-data which differs for Snapshot and Volume.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/417399

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/417399
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.