TypeError: save() takes exactly 2 arguments (1 given)

[Philipp Marek]

From http://logs.openstack.org/43/332943/8/check/gate-tempest-dsvm-full-drbd-devstack-nv/7dad5e1/logs/screen-c-vol.txt.gz#_2016-11-08_12_2http://logs.openstack.org/43/332943/8/check/gate-tempest-dsvm-full-drbd-devstack-nv/7dad5e1/logs/screen-c-vol.txt.gz#_2016-11-08_12_2

 log_http_response /usr/local/lib/python2.7/dist-packages/glanceclient/common/http.py:219
2016-11-08 12:09:29.225 ERROR oslo_messaging.rpc.server [req-a03dfb25-748f-49d9-85a5-802a2442c818 tempest-VolumesV1ActionsTest-1662514908] Exception during message handling
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 155, in _process_incoming
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 225, in dispatch
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 195, in _do_dispatch
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/opt/stack/new/cinder/cinder/volume/manager.py", line 1303, in copy_volume_to_image
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server resource_uuid=volume_id)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 220, in __exit__
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server self.force_reraise()
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 196, in force_reraise
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server six.reraise(self.type_, self.value, self.tb)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/opt/stack/new/cinder/cinder/volume/manager.py", line 1283, in copy_volume_to_image
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server image_service, image_meta)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/opt/stack/new/cinder/cinder/volume/driver.py", line 829, in copy_volume_to_image
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server attach_info, volume = self._attach_volume(context, volume, properties)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server File "/opt/stack/new/cinder/cinder/volume/driver.py", line 942, in _attach_volume
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server volume.save()
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server TypeError: save() takes exactly 2 arguments (1 given)
2016-11-08 12:09:29.225 14682 ERROR oslo_messaging.rpc.server

I believe this is caused by https://review.openstack.org/#/c/332943; it affects eg. the DRBD CI.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/397219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/397219
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=93a26471bb93ff76131a817883e7d37f1b3adc37
Submitter: Jenkins
Branch: master

commit 93a26471bb93ff76131a817883e7d37f1b3adc37
Author: Gorka Eguileor <email address hidden>
Date: Mon Nov 14 15:34:11 2016 +0100

    Pass OVO instance to copy_volume_to_image

    We should be using OVO instances as much as possible in the volume
    manager's code, but we still have some instances of ORM instances being
    passed to drivers.

    This patch fixes only 1 specific case, so there are more cases still
    pending to change to OVOs, which is the call from the
    copy_volume_to_image method in the manager to the respective driver
    method.

    Closes-Bug: #1641611
    Change-Id: If30d3521d3a28488b12ed3bd4c753066b80d39c9

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.0.0b1 development milestone.