Dell SC: Can incorrectly identify if it is failed over

Bug #1631149 reported by Tom Swanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Tom Swanson

Bug Description

Looks like active_backend_id can be None or ''. Only testing against None so if '' came in the driver would id as being in a failed over state.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/383473

Changed in cinder:
assignee: nobody → Tom Swanson (tom-swanson)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/383473
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a1c0fc3b03f0ec72bd51d242d029f71ff298fe82
Submitter: Jenkins
Branch: master

commit a1c0fc3b03f0ec72bd51d242d029f71ff298fe82
Author: Tom Swanson <email address hidden>
Date: Thu Oct 6 16:12:40 2016 -0500

    Dell SC: Can incorrectly identify if it is failed over

    Driver was only checking active_backend_id against None when
    it should have been checking against None or an empty string.

    Change-Id: Ib62b28742f32f3522a92f2f140e23ba5472eef8d
    Closes-Bug: #1631149

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/383918

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/newton)

Reviewed: https://review.openstack.org/383918
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=214678b09f1ab4a45d9b3df73af56a41500fe07c
Submitter: Jenkins
Branch: stable/newton

commit 214678b09f1ab4a45d9b3df73af56a41500fe07c
Author: Tom Swanson <email address hidden>
Date: Thu Oct 6 16:12:40 2016 -0500

    Dell SC: Can incorrectly identify if it is failed over

    Driver was only checking active_backend_id against None when
    it should have been checking against None or an empty string.

    Change-Id: Ib62b28742f32f3522a92f2f140e23ba5472eef8d
    Closes-Bug: #1631149

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 9.1.0

This issue was fixed in the openstack/cinder 9.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.0.0b1

This issue was fixed in the openstack/cinder 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 9.1.0

This issue was fixed in the openstack/cinder 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.