Intermitent Newton unit test failures

[Thomas Goirand]

It looks like some tests are not deterministic and fails "sometimes". It failed for me twice, and worked only once so far, so I'll be blacklisting these tests in my Debian package. Here's the build log:

FAIL: cinder.tests.unit.backup.test_backup.BackupTestCase.test_create_backup_with_temp_snapshot
cinder.tests.unit.backup.test_backup.BackupTestCase.test_create_backup_with_temp_snapshot
----------------------------------------------------------------------
_StringException: Empty attachments:
  stderr
  stdout
pythonlogging:'': {{{
2016-09-14 19:00:54,440 INFO [cinder.coordination] Coordination backend started successfully.
2016-09-14 19:00:54,443 INFO [cinder.rpc] Automatically selected cinder-backup objects version 1.5 as minimum service version.
2016-09-14 19:00:54,446 INFO [cinder.rpc] Automatically selected cinder-backup RPC version 2.0 as minimum service version.
2016-09-14 19:00:54,448 INFO [cinder.rpc] Automatically selected cinder-volume objects version 1.5 as minimum service version.
2016-09-14 19:00:54,451 INFO [cinder.rpc] Automatically selected cinder-volume RPC version 2.2 as minimum service version.
2016-09-14 19:00:54,453 INFO [cinder.rpc] Automatically selected cinder-scheduler objects version 1.5 as minimum service version.
2016-09-14 19:00:54,455 INFO [cinder.rpc] Automatically selected cinder-scheduler RPC version 2.1 as minimum service version.
2016-09-14 19:00:54,491 INFO [cinder.volume.manager] Determined volume DB was empty at startup.
2016-09-14 19:00:54,494 INFO [cinder.volume.manager] Service not found for updating active_backend_id, assuming default for driver init.
2016-09-14 19:00:54,495 INFO [cinder.volume.manager] Image-volume cache disabled for host debian-jessie-rax-dfw-4291811.
}}}

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "cinder/tests/unit/backup/test_backup.py", line 645, in test_create_backup_with_temp_snapshot
    'connector': os_brick.initiator.connector.FakeConnector(None)}
AttributeError: 'module' object has no attribute 'FakeConnector'

The 2nd one is this one, so I'm not pasting it:

https://bugs.launchpad.net/cinder/+bug/1582306

I've previously been able to run all unit tests without a single failure, so that really is non-deterministic.

[Sean McGinnis (sean-mcginnis)]

This was due to some hard coded internal paths in the unit tests that have since been updated.

[Thomas Goirand (thomas-goirand)]

If it "was" there, please link to the code review, so that I can see the patch please. In any case, the status of this bug shouldn't be "Invalid".