snapshot-manage imports snapshots with wrong size

[Adriano]

The manage snapshots feature does not import the snapshots with their real size.
E.g. When managing a snapshot of a volume that was extended after the snapshot was unmanaged, the snapshot will be imported to Cinder with the new volume size.

Steps to reproduce:
1- Create a volume v1 with 10 Gb
2- Create a snapshot s1 from v1
3- Unmanage the snapshot s1
4- Extend the volume v1 to 15 Gb
5- Manage s1

Result:
The snapshot is imported to Cinder with the volume size (15 Gb).

Expected:
The snapshot is imported to Cinder with its real size (10 Gb).

Note: In the example, the snapshot size on backend is still 10 Gb also.

[Andy Hsiang (yh418t)]

hi, unfortunately, i was not able recreate the issue. when i try to unmanage a snapshot, it is removed from the snapshot list as if it was deleted (deleted status in DB). i am not sure how i can re-manage it, or if it was ever in the managed state. When i try to manually manage a snapshot by the command "cinder snapshot-manage <volume> <existing_snapshot>", it'd return a new snapshot creation process with error status. maybe someone with more experience can comment on this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/426162

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/426162
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=767e09b139dc1668f3a20a4c8515c3cfb384e72b
Submitter: Jenkins
Branch: master

commit 767e09b139dc1668f3a20a4c8515c3cfb384e72b
Author: Mykhailo Dovgal <email address hidden>
Date: Fri Jan 27 12:35:41 2017 +0200

    Fix size update error for snapshot-manage operation

    After snapshot-manage operation we have incorrect update
    because the snapshots table in DB doesn't contain 'size' column.
    This patch fix this problem.

    Change-Id: I84031a87803fd5314eb7a605d5439cf3e2c49332
    Closes-Bug: #1623596

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0b1 development milestone.