referencing versionutils.deprecated.NEWTON in oslo.log <3.4.0

[Eric Harney]

cinder/keymgr/__init__.py contains:

    versionutils.deprecation_warning(deprecated, versionutils.NEWTON,
                                     in_favor_of=castellan, logger=LOG)

versionutils.NEWTON does not exist until oslo.log 3.4.0, but Cinder Newton only requires oslo.log>=1.14.0.

It is too late in Newton to bump the global requirements for a newer oslo.log. ( https://review.openstack.org/#/c/366418/ )

[Eric Harney (eharney)]

Should also note: this was found by looking at our pylint tox env.

[Sean McGinnis (sean-mcginnis)]

Additionally, looks like it should actually be versionutils.deprecated.NEWTON in the latest code.

[Steve Martinelli (stevemar)]

We're in the same boat for keystone -- we use versionutils.deprecated.NEWTON and list 1.14.0 as the minimum. https://github.com/openstack/keystone/blob/723208b58698ba14bc54b28ef2a3e8db8a77b538/keystone/common/ldap/__init__.py#L20

[Eric Harney (eharney)]

I think this code in Cinder may have other issues: It looks like the "if api_class == deprecated_barbican" checks etc. are being done before the config file is read, which means they don't work right because they only have the default value. Logging does not work there either.

(This is a result of all of this code executing from __init__ at import time rather than from the API() call.)

[Tony Breeds (o-tony)]

This is clearly a problem but it isn't something we can fix at this stage of the cycle. For the server projects that *can* correct the raw syntax errors.

It's just not reasonable to modify global-requirements.txt to correct this. We know that testing lower bounds isn't something we do now but it is something we *can* do in Ocata.

Packagers should look at what we have in upper-constraints and package that.

Package : oslo-log [oslo-log>=1.14.0] (used by 84 projects)
Re-Release : 20 projects
openstack/castellan [type:library]
openstack/ironic-lib [type:library]
openstack/neutron-lib [type:library]
openstack/os-brick [type:library]
openstack/os-vif [type:library]
openstack/os-win [type:library]
openstack/oslo.cache [type:library]
openstack/oslo.messaging [type:library]
openstack/oslo.privsep [type:library]
openstack/oslo.service [type:library]
openstack/oslo.versionedobjects [type:library]
openstack/python-congressclient [type:library]
openstack/python-karborclient [type:library]
openstack/python-manilaclient [type:library]
openstack/python-monascaclient [type:library]
openstack/python-muranoclient [type:library]
openstack/python-saharaclient [type:library]
openstack/python-tackerclient [type:library]
openstack/tempest-lib [type:library]
openstack/tripleo-common [type:library]
Included in : 28 projects
openstack/barbican [type:service]
openstack/cinder [type:service]
openstack/congress [type:service]
openstack/designate [type:service]
openstack/freezer [type:service]
openstack/freezer-api [type:service]
openstack/glance [type:service]
openstack/heat [type:service]
openstack/ironic [type:service]
openstack/karbor [type:service]
openstack/keystone [type:service]
openstack/magnum [type:service]
openstack/manila [type:service]
openstack/mistral [type:service]
openstack/monasca-api [type:service]
openstack/monasca-log-api [type:service]
openstack/murano [type:service]
openstack/neutron [type:service]
openstack/nova [type:service]
openstack/sahara [type:service]
openstack/searchlight [type:service]
openstack/senlin [type:service]
openstack/solum [type:service]
openstack/tacker ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/370198

[Eric Harney (eharney)]

Bug 1621109 https://bugs.launchpad.net/cinder/+bug/1621109 addresses what I mentioned in comment #4.

[Steve Martinelli (stevemar)]

global-requirements now has 3.11 as the minimum: https://review.openstack.org/#/c/366418/ -- the proposal bot will fix this for keystone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/377967

[Dr. Jens Harbott (j-harbott)]

Just as am additional notes, it is not enough to package upper-constraints, one will also need to set proper dependencies on other packages so that upgrades will work properly, see https://bugs.launchpad.net/bugs/1628883

[Steve Martinelli (stevemar)]

Marking this as fix-released for keystone on the ocata branch, we depend on oslo.log>=3.11.0: https://github.com/openstack/keystone/blob/master/requirements.txt

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: master
Review: https://review.openstack.org/370198
Reason: No longer needed now that Kaitlin's fix has merged on master.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/377967
Reason: https://review.openstack.org/#/c/376992/