wrong iscsi device path with SolidFire and SVIP/Vlan specifications

[Avishay Traeger]

This code assumes a specific format for the iscsi device path:
https://github.com/openstack/os-brick/blob/1.6.1/os_brick/initiator/connectors/iscsi.py#L546

Specifically "/dev/disk/by-path/ip-%s-iscsi-%s-lun-%s"

However, some systems include the port with the IP while others do not. My system based on Centos did this with a Solidfire target, while with other targets the port was not present. I've seen this on the Web as well: http://serverfault.com/questions/170617/howto-show-connected-targets-in-linux

When the port is included attach commands fail.

[John Griffith (john-griffith)]

I think you're hitting this because you're specifying an sf_svip entry without a port. I recently pushed an update to manuals to indicate this was needed:
    https://review.openstack.org/#/c/356685/
    (Bug: https://bugs.launchpad.net/openstack-manuals/+bug/1614243)

That being said, I can/should most certainly make the driver more robust and just use a default if you omit it in the conf entry. I'll go ahead and do that and associate it with this bug.

Thanks!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/366475

[Avishay Traeger (avishay-il)]

Thanks John, adding the port did the trick!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370324

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/366475
Reason: So this actually is addressed already (inadvertently) in one of the Cheesecake patches that unfortunately landed just after M closed:

https://review.openstack.org/#/c/299746/

[John Griffith (john-griffith)]

Note this actually only impacts releases prior to current stable (Newton). Patch to Mitaka proposed.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370324
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=da77382f32ebe1f7f028054482fa1dceb1703530
Submitter: Jenkins
Branch: stable/mitaka

commit da77382f32ebe1f7f028054482fa1dceb1703530
Author: John Griffith <email address hidden>
Date: Wed Sep 14 11:13:14 2016 -0600

    Add iscsi port to sf_svip arg if not provided

    With things like VLAN support it may be necessary for
    an admin to specify the sf_svip (IP) address. The problem
    is that when this is specified if the admin forgets to include
    the port suffix to the SVIP address it may not work on certain
    distros (inparticular RHEL variants).

    This patch just adds a simple check when the endpoint is created
    to make sure the port suffix is included, if it's not it
    automatically adds the default 3260.

    NOTE: This is not a backport, the Cheesecake code has an
    inadvertent fix (albeit it could be improved) that didn't
    merge in Mitaka.

    Change-Id: Id2a99ff927d1fb9e40fab10beb0db5e4f302ae70
    Closes-Bug: #1619941