During a rolling upgrade, volume creation can fail with 'volume_type cannot be None'

[Nate Potter]

During the rolling upgrade process, the first things to be upgraded (I believe) are the database and the c-api. After these two steps it's assumed that the cloud should still be functional, given the rpc version pinning and OVO work.

At this point in the upgrade it's possible for volume creation to fail, saying that volume_type cannot be None. This is because in mitaka volume creation with a type of None was supported, but in master a commit changed the way this worked, so https://review.openstack.org/#/c/353665/1 was merged to the scheduler service to fix that. However, at this point in the rolling upgrade process the API has been updated but the scheduler still hasn't, so the exception is thrown.

Perhaps some check should be added in the API side to ensure that an exception won't be thrown if the scheduler is still in mitaka, or the fix linked above could be backported to mitaka to mitigate this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/363928

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nate Potter (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/363928
Reason: Backport isn't the way to go for this fix

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/368027

[Michal Dulko (michal-dulko-f)]

@Nate: This wasn't trivial, but I finally found why this was happening. Seems like my patch should fix it, but please validate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/368027
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=91bdf9de4c1e0726892384605704d87b318e7a69
Submitter: Jenkins
Branch: master

commit 91bdf9de4c1e0726892384605704d87b318e7a69
Author: Michał Dulko <email address hidden>
Date: Fri Sep 9 16:01:27 2016 +0200

    Fix creating typeless volumes with Mitaka's c-sch

    In Mitaka as a workaround for creating volumes without volume type c-api
    was sending an empty dictionary as request_spec['volume_type'] in
    create_volume() RPC cast to scheduler. This changed in Newton and we're
    handling this situation directly in scheduler, but when running Newton's
    c-api with Mitaka's c-sch we should mimic older behavior. This patch
    implements that.

    Change-Id: I3dbb1934f3d8e68fef49f56155cbf59bc5fadc3a
    Closes-Bug: 1619008

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/374745

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374745
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=72a1c5dfa2a0ddd650f720cc36ae9b61b5972a19
Submitter: Jenkins
Branch: stable/newton

commit 72a1c5dfa2a0ddd650f720cc36ae9b61b5972a19
Author: Michał Dulko <email address hidden>
Date: Fri Sep 9 16:01:27 2016 +0200

    Fix creating typeless volumes with Mitaka's c-sch

    In Mitaka as a workaround for creating volumes without volume type c-api
    was sending an empty dictionary as request_spec['volume_type'] in
    create_volume() RPC cast to scheduler. This changed in Newton and we're
    handling this situation directly in scheduler, but when running Newton's
    c-api with Mitaka's c-sch we should mimic older behavior. This patch
    implements that.

    Change-Id: I3dbb1934f3d8e68fef49f56155cbf59bc5fadc3a
    Closes-Bug: 1619008
    (cherry picked from commit 91bdf9de4c1e0726892384605704d87b318e7a69)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 9.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 9.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.0.0b1 development milestone.