c-vol, c-sched and c-bak can't start with MySQL-Python driver

Bug #1613624 reported by Ivan Kolodyazhny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Ivan Kolodyazhny

Bug Description

https://github.com/openstack/cinder/blob/0db18b8351255dfe5a8f0749aa5e0211d430848a/cinder/db/sqlalchemy/api.py#L401 will cause SQL syntax error. This code works on gates, because we use PyMSQL driver with connection string like 'mysql+pymysql://'

http://paste.openstack.org/show/558338/

Ivan Kolodyazhny (e0ne)
Changed in cinder:
importance: Undecided → Critical
assignee: nobody → Ivan Kolodyazhny (e0ne)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/355837

Changed in cinder:
assignee: Ivan Kolodyazhny (e0ne) → Gorka Eguileor (gorka)
status: New → In Progress
Changed in cinder:
assignee: Gorka Eguileor (gorka) → Ivan Kolodyazhny (e0ne)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/355837
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=50e6073539a721fc57d0bfaf43dc7f4b3706b501
Submitter: Jenkins
Branch: master

commit 50e6073539a721fc57d0bfaf43dc7f4b3706b501
Author: Gorka Eguileor <email address hidden>
Date: Tue Aug 16 12:26:21 2016 +0200

    Fix mysql binary comparison

    MySQL doesn't do case sensitive filtering by default, so our DB API
    forces comparisons to be case sensitive when looking for hosts.

    Existing code was not being tested at the gate because our check to
    confirm a MySQL connection was too strict and the actual operator used
    for the comparison was wrong.

    This patch improves the connection type check to be more inclusive -now
    the code path it will be run at the gate- and it fixes the operator to
    use the right one.

    Change-Id: Ie2da2eabbab1eb64106f99845dc82a60de14f036
    Closes-Bug: #1613624

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 9.0.0.0b3

This issue was fixed in the openstack/cinder 9.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.