[liberty][mitaka] Netapp: incorrect share usage during create volume from image

[Ivan Kolodyazhny]

NetApp dataontap NFS driver both in Liberty and Mitaka is affected

Detailed bug description:
when user creates bunch of VMs using 'Boot from volume (creates a new volume)' Horizon shows that volumes have been created on different NFS shares (have been distributed almost evenly between different shares). Actually almost all volumes have been created on one of the configured shares.
So there are 2 issues in this case:
 - cinder doesn't distribute volumes between back-end shares
 - os-vol-host-attr:host property is incorrectly reported for some volumes

> for vol_id in $(cinder list --tenant 237abf0b66c84a8aa3fcf8399b84995f | sed '1,3d' | sed '$d' | sed 's/\ //g' | cut -f2 -d'|'); do vol_host=$(cinder show $vol_id | grep os-vol-host-attr:host | sed 's/\ //g' | cut -f3 -d'|'); echo "$vol_host $vol_id"; done | sort -k1 | cut -f1 -d ' ' | uniq -c
     27 str:netapp@cinder_netapp#172.18.52.240:/vol_cin2
     33 str:netapp@cinder_netapp#172.18.52.240:/vol_cin3
     30 str:netapp@cinder_netapp#172.18.52.240:/vol_cin4

I expect 30 volumes on 172.18.52.240:/vol_cin4 share, but actually only 4 are there

> mount | grep vol_cin
172.18.52.240:/vol_cin1 on /var/lib/cinder/mnt/38bc0a0c3d2f51eaae54acf7edd7a718 type nfs (rw,addr=172.18.52.240)
172.18.52.240:/vol_cin2 on /var/lib/cinder/mnt/f7be1a30ac7d2a5bf5d64a909665ca93 type nfs (rw,addr=172.18.52.240)
172.18.52.240:/vol_cin3 on /var/lib/cinder/mnt/5f779d92fd63c7ce63935cdced8b474b type nfs (rw,addr=172.18.52.240)
172.18.52.240:/vol_cin4 on /var/lib/cinder/mnt/f72992e58017c3e7f5b81fd75487eecb type nfs (rw,addr=172.18.52.240)

> for mp in $(mount | grep vol_cin | cut -f3 -d ' '); do echo "$mp $(ls $mp/volume* | wc -l)"; done
/var/lib/cinder/mnt/38bc0a0c3d2f51eaae54acf7edd7a718 382
/var/lib/cinder/mnt/f7be1a30ac7d2a5bf5d64a909665ca93 4
/var/lib/cinder/mnt/5f779d92fd63c7ce63935cdced8b474b 14
/var/lib/cinder/mnt/f72992e58017c3e7f5b81fd75487eecb 4

Steps to reproduce:
spawn VMs using 'Boot from volume (creates a new volume)' or create volume from image, check os-vol-host-attr:host property for volumes, check actual place where volume file has been created

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/352924
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a5b0c7b36c0f62b3ca76f5f7e4bde5b00a5aa1db
Submitter: Jenkins
Branch: stable/mitaka

commit a5b0c7b36c0f62b3ca76f5f7e4bde5b00a5aa1db
Author: Ivan Kolodyazhny <email address hidden>
Date: Tue Aug 9 17:07:08 2016 +0300

    Fix _is_share_clone_compatible for NetApp NFS storage

    _is_share_clone_compatible doesn't compare filtered NFS share
    and volume host assigned by Scheduler. This patch fixes it.

    Data ONTAP driver is refactored in Newton so we don't need this
    fix in master.

    Closes-Bug: #1611367
    Change-Id: I1b18282be474386275c0ddd0dc2f8272b425d39b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 8.1.1 release.