One location missed for coordination=True on service start

[Carl Pecinovsky]

There were recent cinder changes implementing "blueprint cinder-volume-active-active-support" which added "coordination=True" param to cinder volume service start logic. However, it looks like one location was missed in volume.py if cinder multi-backends are not enabled.

     else:
         server = service.Service.create(binary='cinder-volume')

[Michal Dulko (michal-dulko-f)]

Uh, oh. You're right, I've only tested it in multibackend env.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332925

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332925
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=de3794ad93081a23ee0dc75880cbd2dfa5b9a51f
Submitter: Jenkins
Branch: master

commit de3794ad93081a23ee0dc75880cbd2dfa5b9a51f
Author: Carl Pecinovsky <email address hidden>
Date: Wed Jun 22 13:04:28 2016 -0400

    Add missing coordination=True on service start

    In the main() for starting the volume service, the coordination
    param needs to be passed on Service.create when
    CONF.enabled_backends is False. This is already being done when
    all cinder services are starting up, so just an oversight.

    Change-Id: I036e3baf15d848125e115e9f146af1c930c6faba
    Closes-Bug: #1594835

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.