3par iscsi host creation fails while querying host using iqn
Bug #1590180 reported by
Jay Mehta
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Undecided
|
Jay Mehta |
Bug Description
iscsi host creation first searches existing host using iqn. This search is done by querying queryHost() which accepts a list of iqn.
The iscsi_iqn argument from _create_
This type checking and type conversion logic is already implemented. But after queryHost() which would cause failure in queryHost().
This can be fixed by repositioning data type conversion of formal parameter 'iscsi_iqn' in _create_
Changed in cinder: | |
assignee: | nobody → Jay Mehta (jay-mehta) |
Changed in cinder: | |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/317763 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=7a066eb71e7 e9a12050506af26 596ababdc28148
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7a066eb71e7e9a1 2050506af26596a babdc28148
Author: Jay Mehta <email address hidden>
Date: Tue May 17 16:05:25 2016 -0700
Fixed _create_ 3par_iscsi_ host(), added unit test for 3PAR
Updated signature of _create_ 3par_iscsi_ host(), formal parameter
'iscsi_iqn' now only accepts list. Its only caller _create_host()
will convert always a single string only iscsi_iqn to list.
Updated 3PAR ISCSI driver version number to 3.0.11.
Covered negative scenarios with below unit tests: host_chap_ enabled_ and_host_ without_ chap_cred( ) connection_ for_clear_ chap_creds_ not_found( ) connection_ for_clear_ chap_user_ key_bad_ request( ) connection_ for_clear_ chap_pass_ key_bad_ request( )
1. Added new test_create_
to cover case:
* create_host() when CHAP is enabled and host is w/o CHAP creds
2. Added test_terminate_
to cover case:
* clear CHAP USER KEY and PASS KEY fails with HTTPNotFound
3. Added test_terminate_
to cover case:
* clear CHAP USER KEY fails with HTTPBadRequest
4. Added test_terminate_
to cover case:
* clear CHAP PASS KEY fails with HTTPBadRequest
Closes-Bug: #1590180 4b66b925010e554 c12e43463e5
Change-Id: I5cea392d482aa3