the method _add_to_threadpool is defined repated

Bug #1588200 reported by wuyuting
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
wuyuting

Bug Description

The method _add_to_threadpool is defined repeated in both cinder.volume.Manager Class and cinder.manager.SchedulerDependentManager Class. Actually, SchedulerDependentManager is the parent class of Manager. Therefore, there's no need to redefine the method again.

wuyuting (wytdahu)
Changed in cinder:
assignee: nobody → wuyuting (wytdahu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/324278

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/324278
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=b47ca6377e77e409448e58fe0350241dae6ff181
Submitter: Jenkins
Branch: master

commit b47ca6377e77e409448e58fe0350241dae6ff181
Author: wuyuting <email address hidden>
Date: Thu Jun 2 03:48:13 2016 -0400

    Remove the duplicated definition of _add_to_threadpool

    Method _add_to_threadpool is defined repeated in both cinder.volume.Manager
    class and cinder.manager.SchedulerDependentManager class. Actually,
    SchedulerDependentManager is the parent class of Manager. Therefore,
    there's no need to redefine the method again. This patch removes the
    duplicated definition of the method in cinder.volume.Manager.

    Change-Id: I809fbd2dd8704cce1e2e3eb0c419740ee549b0a6
    Closes-Bug: #1588200

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 9.0.0.0b2

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.