driver_utils doesn't allow for safe setting of DriverInitiatorData

Bug #1588088 reported by Patrick East
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Patrick East

Bug Description

Right now when we call driver_initiator_data_update() on the db api we give a model update that contains potentially more than one entry to add/remove/update. This makes it very difficult to make smarter (safer) updates asynchronously.

Ideally we would have a more fine grained method to help do this on the driver_utils.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/324155

Changed in cinder:
assignee: nobody → Patrick East (patrick-east)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/324155
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cf19bc16b95b6f04cae35b0756643a93abb1b34f
Submitter: Jenkins
Branch: master

commit cf19bc16b95b6f04cae35b0756643a93abb1b34f
Author: Patrick East <email address hidden>
Date: Wed Jun 1 12:02:31 2016 -0700

    Give more fine grained access to DriverInitiatorData

    Previously we were setting a whole model update, whereas now we only
    do one value at a time. This will allow for easier handling of doing
    the insert if not exist and reporting back what happened.

    The older method to do this was better suited to the model_update from
    initialize_connection, but we don’t need a ‘all-in-one’ kind of method
    anymore.

    Change-Id: I57778f1807d1814c536d62757d6ad10c920b6101
    Closes-Bug: #1588088

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 9.0.0.0b2

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.