SolidFire Driver: Volume manage should get ceiling of volume size

[Yafei Yu]

The function manage_existing_object_get_size returns the floor of volume size in solidfire driver.But in the driver API: "When calculating the size, round up to the next GB." See https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L1814. So it should return the ceiling of volume size, not the floor.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/323191

[John Griffith (john-griffith)]

Thanks for looking at this, but actually that's not quite accurate. SolidFire minimum size if 1G and volumes are sized in 1G increments. Also, for things like manage because we use 1G increments and Cinder uses/requires 1G increments there should be no floor or ceiling conversions necessary.

[Yafei Yu (yu-yafei)]

Hi, John
In the driver API: "When calculating the size, round up to the next GB." See https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L1814. So I think the solidfire driver should be consistent with the driver API.

[OpenStack Infra (hudson-openstack)]

Change abandoned by yuyafei (<email address hidden>) on branch: master
Review: https://review.openstack.org/323191

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326776

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326776
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f14aace2c21d6605e12150c54cdb1fd714c112ad
Submitter: Jenkins
Branch: master

commit f14aace2c21d6605e12150c54cdb1fd714c112ad
Author: yuyafei <email address hidden>
Date: Wed Jun 8 09:36:49 2016 +0800

    SolidFire driver should return ceiling of volume size

    The function manage_existing_get_size returns the floor of volume size
    in solidfire driver. But in the driver API:"When calculating the size,
    round up to the next GB." The solidFire driver should be consistent
    with the driver API. This patch fixes it by returning the ceiling of
    volume size.

    Change-Id: Icc4f893b9e18dc525b85b45f3307663b6d8884ed
    Closes-Bug: #1586306

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.