volume_attachment_get_by_* only returns first occurence

[John Griffith]

The cinder.db.sqlalchemy.apy implementation of volume_attachment_get_by_host and _get_by_instance_uuid only returns the first item found. Should probably return all active records, especially in the case of supporting multi-attach.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/321095

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/324049

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/321095
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=61a63dc77dc6ba6245c387f7d65b62b5ca6e8f30
Submitter: Jenkins
Branch: master

commit 61a63dc77dc6ba6245c387f7d65b62b5ca6e8f30
Author: John Griffith <email address hidden>
Date: Wed May 25 10:04:50 2016 -0600

    Fix attachment_get_by_* to return entire list

    Commit 10d54216871fde27172fbcb1a3c9bfec59b824c2 added the
    ability to query volume_attachments by host and instance_uuid.

    Minor bug however is that the original implementation also used
    a "first()" filter, so regardless of how many attachments might
    exist, only one was being returned.

    The volume_attachments object code assumes we receive a list, as
    do a number of other places. So, this patch changes the names of
    those get methods to "get_all_by_xxx" to eliminate any confusion
    and updates things to use the list appropriately.

    Change-Id: I63e4faf8a7ee3528a4dfbd7bf4e61b607ad86841
    Closes-Bug: #1585690

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/324049