unexpected function was called in _migrate_volume_generic

[Yusuke Hayashi]

When executing migrate or retype for the volume created by create_volume_from_snapshot or create_cloned_volume with the driver which does not have original migrate_volume, unexpected function was called in _migrate_volume_generic.

(1) The volume was created by create_volume_from_snapshot
    -> When executing migrate volume for it, create_volume_from_snapshot was called to create
       migration destination volume in _migrate_volume_generic.

(2) The volume was created by create_cloned_volume
    -> As above, create_cloned_volume was called in _migrate_volume_generic.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316086

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316086
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f5f3ca0a55deb0a2648e43f222ebbbc121293f69
Submitter: Jenkins
Branch: master

commit f5f3ca0a55deb0a2648e43f222ebbbc121293f69
Author: Yusuke Hayashi <email address hidden>
Date: Thu May 12 21:59:53 2016 +0900

    Unexpected function is called in _migrate_volume_generic

    When calling _migrate_volume_generic with the volume created by
    create_volume_from_snapsot or create_cloned_volume,
    create_volume is not called to create dest-volume for migration.

    Instead of the function, create_volume_from_snapshot or create_cloned_volume
    is called to create the dest-volume.

    This is because the source volume for migration has info of 'snapshot_id'
    or 'source_volid'. So, This patch temporarily removes the keys and sets after
    migration.

    Change-Id: Ibeeb119b72c0a686000f175187c1bfa359bbf6a2
    Closes-Bug: #1580013

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/473568

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/473568
Reason: Ok.

Note: this patch was already approved and the only reason it's still even up for review is because I updated it to depend on another patch required to fix CI. Leaving it broken would have, eventually, resulted in a bunch of "recheck" commands causing it to merge, rather than requiring re-review.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/473568

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/36380
Submitter: Pkgs Jenkins <email address hidden>
Branch: mcp/1.0/mitaka

Commit: 7e967d4bfb5887f9fda18076d3b59824fc9adaa1
Author: Yusuke Hayashi <email address hidden>
Date: Thu Aug 31 13:24:22 2017

Unexpected function is called in _migrate_volume_generic

When calling _migrate_volume_generic with the volume created by
create_volume_from_snapsot or create_cloned_volume,
create_volume is not called to create dest-volume for migration.

Instead of the function, create_volume_from_snapshot or create_cloned_volume
is called to create the dest-volume.

This is because the source volume for migration has info of 'snapshot_id'
or 'source_volid'. So, This patch temporarily removes the keys and sets after
migration.

Change-Id: Ibeeb119b72c0a686000f175187c1bfa359bbf6a2
Closes-Bug: #1580013
(cherry picked from commit f5f3ca0a55deb0a2648e43f222ebbbc121293f69)