Inconsistent method signatures for initialize_connection in drivers

[John Griffith]

Some drivers take 2 arguments, some take 3, reference driver.py takes 3 with the last having a default... others should do that too.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/313154

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/313200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313200
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1058f298e5ac54ae91e98c3874a09c857d04f008
Submitter: Jenkins
Branch: master

commit 1058f298e5ac54ae91e98c3874a09c857d04f008
Author: Patrick East <email address hidden>
Date: Thu May 5 16:29:56 2016 -0700

    Move initiator_data access to helper methods

    This changes the flow for how a driver would access the initiator_data
    information. Previously it was passed in at initialize_connection
    and then a update dictionary merged in with the return of that method.
    We will now just have drivers call helper util methods that can get
    and set the data.

    There are a few benefits of doing this:

    * Drivers can synchronize access to the data, if they need to. It won’t
    force any locks are anything on someone who doesn’t care. Future
    iterations will make this do a conditional update so drivers won’t need
    to use locks around it either.
    * No more optional params on initialize_connection, meaning all drivers
    have the same signature again.
    * Less junk in the manager.
    * Less db calls for everyone!

    Change-Id: I9b90fafdbf290c7d7141b6ce4f83711f0fcd528f
    Closes-Bug: #1578801
    Closes-Bug: #1578864

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/313154