failback causes cinder to enable backend which may be frozen before failover
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Medium
|
jiamin |
Bug Description
Steps to Reproduce:
freeze host
failover host
failback host
attempt to create volume
Actual Results: Can modify backend even though it's frozen.
Expected Results: Backend is frozen and must be thawed.
I think it better is change the failover-host function in manager.py from:
3350 if secondary_
3351 service.
3352 service.
3353 service.disabled = False
3354 service.
3355 service.save()
to:
3350 if secondary_
3351 service.
3352 service.
3353 if service.frozen:
3354 service.disabled = True
3355 service.
3356 else:
3357 service.disabled = False
3358 service.
3359 service.save()
if not change the code, there is another problem too, after failback, the 'frozen' filed in the result of "cinder service-list --withreplicaiton True" will be still True and confuse user.
$ cinder service-list --withreplication True
+------
| Binary | Host | Zone | Status | State | Updated_at | Replication Status | Active Backend ID | Frozen | Disabled Reason |
+------
| cinder-backup | charmander | nova | enabled | up | 2016-05-
| cinder-scheduler | charmander | nova | enabled | up | 2016-05-
| cinder-volume | charmander@
summary: |
- failback causes cinder to enable backend when frozen + failback causes cinder to enable backend when it is frozen before + failover |
description: | updated |
description: | updated |
Changed in cinder: | |
assignee: | nobody → jiamin (shljia) |
summary: |
- failback causes cinder to enable backend when it is frozen before + failback causes cinder to enable backend which may be frozen before failover |
Changed in cinder: | |
importance: | Undecided → Medium |
Fix proposed to branch: master /review. openstack. org/312334
Review: https:/