Forced backup can fail if backend clones volumes

[Ollie Leahy]

Forced backup fails for some backends. The following trace appears in cinder-backup.log, and the new backup goes into the state 'error'

2016-04-14 16:37:34.859 11683 DEBUG hplefthandclient.http [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] RESP BODY:
 _http_log_resp /opt/stack/venv/cinder-20160405T101007Z/lib/python2.7/site-packages/hplefthandclient/http.py:169
 2016-04-14 16:37:34.859 11683 WARNING cinder.volume.driver [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] ISCSI provider_location not stored, using discovery
 2016-04-14 16:37:34.860 11683 DEBUG oslo_concurrency.processutils [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] Running cmd (subprocess): sudo cinder-rootwrap /etc/cinder/rootwrap.conf iscsiadm -m discovery -t sendtargets -p ha-volume-manager execute /opt/stack/venv/cinder-20160405T101007Z/lib/python2.7/site-packages/oslo_concurrency/processutils.py:326
 2016-04-14 16:37:34.951 11683 DEBUG oslo_concurrency.processutils [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] CMD "sudo cinder-rootwrap /etc/cinder/rootwrap.conf iscsiadm -m discovery -t sendtargets -p ha-volume-manager" returned: 4 in 0.091s execute /opt/stack/venv/cinder-20160405T101007Z/lib/python2.7/site-packages/oslo_concurrency/processutils.py:356
 2016-04-14 16:37:34.952 11683 DEBUG oslo_concurrency.processutils [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] u'sudo cinder-rootwrap /etc/cinder/rootwrap.conf iscsiadm -m discovery -t sendtargets -p ha-volume-manager' failed. Not Retrying. execute /opt/stack/venv/cinder-20160405T101007Z/lib/python2.7/site-packages/oslo_concurrency/processutils.py:404
 2016-04-14 16:37:34.952 11683 ERROR cinder.volume.driver [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] ISCSI discovery attempt failed for:ha-volume-manager
 2016-04-14 16:37:34.953 11683 DEBUG cinder.volume.driver [req-3125e1a4-6e49-4981-ab5e-dbca4da618e5 660ed360dab54f01bc764d2ecf7986a1 f398e40c036b48619eb3d10b78233e33 - - -] Error from iscsiadm -m discovery: iscsiadm: Cannot resolve host ha-volume-manager. getaddrinfo error: [Name or service not known]

 iscsiadm: cannot resolve host name ha-volume-manager
 iscsiadm: cannot resolve host name ha-volume-manager

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/309086

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309086
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=616a2bd34dee74931ead0d40596da98191ba6f77
Submitter: Jenkins
Branch: master

commit 616a2bd34dee74931ead0d40596da98191ba6f77
Author: Ollie Leahy <email address hidden>
Date: Thu Apr 21 17:19:16 2016 +0100

    Add provider_location to cloned volume

    Forced backup was failing when the driver returned a 'provider_location'
    for a cloned volume, because the return value for create_cloned_volume()
    was ignored in _create_temp_cloned_volume().

    Change-Id: I709996316e4c212243629e461d36da4152e995e4
    Closes-Bug: 1573126

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314988

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314988
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d6a502b74d9be9003c6a304c5c4b0ed435ff030c
Submitter: Jenkins
Branch: stable/mitaka

commit d6a502b74d9be9003c6a304c5c4b0ed435ff030c
Author: Ollie Leahy <email address hidden>
Date: Thu Apr 21 17:19:16 2016 +0100

    Add provider_location to cloned volume

    Forced backup was failing when the driver returned a 'provider_location'
    for a cloned volume, because the return value for create_cloned_volume()
    was ignored in _create_temp_cloned_volume().

    Change-Id: I709996316e4c212243629e461d36da4152e995e4
    Closes-Bug: 1573126
    (cherry picked from commit 616a2bd34dee74931ead0d40596da98191ba6f77)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 8.1.0 release.