Wrong checks whether only one cinder volume service when volume creation

[Lisa Li]

Currently when creating volume from source or snapshot, it checks whether there are only one cinder-volume service in system.

It uses following check:
         services = objects.ServiceList.get_all_by_topic(elevated,
                                                         'cinder-volume',
                                                        disabled=True)

This call returns disabled cinder-volume service, which is wrong. We should find out non-disabled cinder-volume services.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/308148

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/308148
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/308148
Reason: No updates for several months. Feel free to restore and update if this is still desired.