snapshot-manager commit quota twice

[Cao ShuFeng]

snapshot-manager commit quota twice both in cinder-api and cinder-vol.
The quota should be update only once.

This is the reproduce step.
http://paste.openstack.org/show/492041/

It's commit twice,
First commit:
https://github.com/openstack/cinder/blob/ca88012a1509b08d45899aa0604f692b0388b67d/cinder/volume/api.py#L802
The second commit:
https://github.com/openstack/cinder/blob/b5fdd31619b551995a5c7ec3a7305645fbc774a2/cinder/volume/flows/manager/manage_existing_snapshot.py#L204

[Cao ShuFeng (caosf-fnst)]

The question is which one should I delete?
Can anyone help me?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/298522

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/298522
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=9809769707352e756575b02a4520248b18c8559b
Submitter: Jenkins
Branch: master

commit 9809769707352e756575b02a4520248b18c8559b
Author: Cao ShuFeng <email address hidden>
Date: Tue Mar 29 12:04:33 2016 +0800

    remove extra quota commit of manage snapshot

    When manage an existing snapshot of a volume, cinder-api and cinder-vol
    both commit quota. This result in an extra commit.This change remove
    the extra commit in the cinder-api.

    Change-Id: Ic93ceebfcd9703549eb5f6b41e404a36ce24daae
    Closes-bug: #1562830

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/331620

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/331675

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jay Conroy (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/331620
Reason: Incorrect Change-Id, new review up with corrected Id https://review.openstack.org/#/c/331675/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/331675
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0520389f200c7b14dd3f7844f23988abe407e93e
Submitter: Jenkins
Branch: stable/mitaka

commit 0520389f200c7b14dd3f7844f23988abe407e93e
Author: Cao ShuFeng <email address hidden>
Date: Tue Mar 29 12:04:33 2016 +0800

    remove extra quota commit of manage snapshot

    When manage an existing snapshot of a volume, cinder-api and cinder-vol
    both commit quota. This result in an extra commit.This change remove
    the extra commit in the cinder-api.

    Closes-bug: #1562830
    (cherry picked from commit 9809769707352e756575b02a4520248b18c8559b)

    Change-Id: Ic93ceebfcd9703549eb5f6b41e404a36ce24daae

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/cinder 8.1.0 release.