IBM FlashSystem driver does not honor create from snapshot volume size

[Sean McGinnis]

create_volume_from_snapshot can specify a volume size larger than the orginal snapshot. Current code does not appear to handle this size difference.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/336092
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Xinli Guan (xinli-v)]

YanLin;

During investigation of patch 336092, I figured out that you have already created a patch to fix the issue regarding the larger size of the volume.

Now, the core team wants to switch back to the solution that each driver will fix the the issue locally instead of using a generic solution.

Could you please restor your patch and finish it?

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jay Bryant (<email address hidden>) on branch: master
Review: https://review.openstack.org/336092
Reason: It was decided that we wouldn't go down this path so we this patch can be abandoned.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/511346

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/511346
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=927367cd9af6adf260bea4da4dcc5cc94eaa7b13
Submitter: Zuul
Branch: master

commit 927367cd9af6adf260bea4da4dcc5cc94eaa7b13
Author: John Cates <email address hidden>
Date: Wed Oct 11 16:58:50 2017 -0500

    FlashSystems: permit snapshot/clone volumes larger than source

    Permit clone volumes and volumes created from snapshots to
    be larger than their source volumes; implemented in response
    to failures in the following CI tests:
      * VolumesSnapshotTestJSON.test_volume_from_snapshot
      * VolumesCloneTest.test_create_from_volume

    Change-Id: I21511e5c4db62563c61815c1671e8bb44ad3f427
    Closes-Bug: #1560655

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/531236

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: driverfixes/ocata
Review: https://review.openstack.org/531239

[John Cates (jccates)]

Redhat asked me to submit this fix to stable/pike and driverfixes/ocata.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531239
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=47192b622f53ebaf9cd0f1781e650e4f064ce70b
Submitter: Zuul
Branch: driverfixes/ocata

commit 47192b622f53ebaf9cd0f1781e650e4f064ce70b
Author: John Cates <email address hidden>
Date: Wed Oct 11 16:58:50 2017 -0500

    FlashSystems: permit snapshot/clone volumes larger than source

    Permit clone volumes and volumes created from snapshots to
    be larger than their source volumes; implemented in response
    to failures in the following CI tests:
      * VolumesSnapshotTestJSON.test_volume_from_snapshot
      * VolumesCloneTest.test_create_from_volume

    Change-Id: I21511e5c4db62563c61815c1671e8bb44ad3f427
    Closes-Bug: #1560655
    (cherry picked from commit 927367cd9af6adf260bea4da4dcc5cc94eaa7b13)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531236
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=78c2ff9f9d213dc81027ebf7470dfd6d6cd54be3
Submitter: Zuul
Branch: stable/pike

commit 78c2ff9f9d213dc81027ebf7470dfd6d6cd54be3
Author: John Cates <email address hidden>
Date: Wed Oct 11 16:58:50 2017 -0500

    FlashSystems: permit snapshot/clone volumes larger than source

    Permit clone volumes and volumes created from snapshots to
    be larger than their source volumes; implemented in response
    to failures in the following CI tests:
      * VolumesSnapshotTestJSON.test_volume_from_snapshot
      * VolumesCloneTest.test_create_from_volume

    Change-Id: I21511e5c4db62563c61815c1671e8bb44ad3f427
    Closes-Bug: #1560655
    (cherry picked from commit 927367cd9af6adf260bea4da4dcc5cc94eaa7b13)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/560609

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/560609
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=06d77dbc1e8326124fa5a0607a006055c6c874c9
Submitter: Zuul
Branch: stable/ocata

commit 06d77dbc1e8326124fa5a0607a006055c6c874c9
Author: John Cates <email address hidden>
Date: Wed Oct 11 16:58:50 2017 -0500

    FlashSystems: permit snapshot/clone volumes larger than source

    Permit clone volumes and volumes created from snapshots to
    be larger than their source volumes; implemented in response
    to failures in the following CI tests:
      * VolumesSnapshotTestJSON.test_volume_from_snapshot
      * VolumesCloneTest.test_create_from_volume

    Change-Id: I21511e5c4db62563c61815c1671e8bb44ad3f427
    Closes-Bug: #1560655
    (cherry picked from commit 927367cd9af6adf260bea4da4dcc5cc94eaa7b13)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.7 release.