init_host_with_rpc is checking for replication in stats, which isn't used any more

Bug #1556315 reported by Patrick East
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Patrick East

Bug Description

We are doing a check like:

if stats and stats.get('replication', False):

which is always going to fail, because just the 'replication' key isn't a thing anymore. We should only be keying off of replication enabled.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/291946

Changed in cinder:
assignee: nobody → Patrick East (patrick-east)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/291946
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=178a462c670bbf4a09949065d207519089d484a9
Submitter: Jenkins
Branch: master

commit 178a462c670bbf4a09949065d207519089d484a9
Author: Patrick East <email address hidden>
Date: Fri Mar 11 15:28:27 2016 -0800

    Fixup stats key for replication in init_host_with_pc

    We were looking for just ‘replication’ in stats, but that key isn’t
    used by anyone and would always be false. We instead want to be keying
    off of just replication_enabled.

    Change-Id: I8f4ef8d5c6594c1548958ebac2ff63b79429cd0b
    Closes-Bug: #1556315

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0rc1

This issue was fixed in the openstack/cinder 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.