RPC client recreates exception instance failed

[zengchen]

The rpc client will recreate exception instance if the exception of remote calling happens. But, recreating will fail, we will get an error : "__init__() got multiple values for keyword argument message". Because the arguments given to __init__ of CinderException are like this: __init__("some message", **{'message' : "some message", 'code' : 500}).

[Michal Dulko (michal-dulko-f)]

Can you provide reproduction steps?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290217

[zengchen (chenzeng2)]

This bug will happen by calling remote interface through rpc's 'call' method. If an exception of remote interface happens and throw it by raising, then rpc client will catch it and recreate the exception instance, but will fail.

The reproduction steps are like these:
1. find a remote interface which will be called by rpc's 'call' method and will raise an exception instance of CinderException

2.call this interface on the api, then you will find the error happens at /usr/local/lib/python2.7/dist-packages/oslo_messaging/_drivers/common.py : deserialize_remote_exception(224)

[OpenStack Infra (hudson-openstack)]

Change abandoned by zengchen (<email address hidden>) on branch: master
Review: https://review.openstack.org/290217

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.