iscsi_target table removal breaks rolling upgrade
Bug #1553079 reported by
Michal Dulko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Critical
|
Gorka Eguileor |
Bug Description
Rolling upgrades was broken when iscsi_target table was dropped on https:/
As volume_delete() in db.api was referencing this table in the query, its removal makes it impossible to delete a volume by Liberty cinder-volume.
We cannot stop using a table and drop it in the same release for rolling upgrades to work, we have to stop using it in one release and then drop it in the next or in the post rolling upgrade mechanism (which is still not in place).
Changed in cinder: | |
assignee: | nobody → Gorka Eguileor (gorka) |
importance: | Undecided → Critical |
status: | New → In Progress |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/287800 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=e51edb0dce9 d69f1798f226ba1 ce927c283688ea
Committed: https:/
Submitter: Jenkins
Branch: master
commit e51edb0dce9d69f 1798f226ba1ce92 7c283688ea
Author: Gorka Eguileor <email address hidden>
Date: Thu Mar 3 14:37:29 2016 +0100
Readd iscsi_target table
Rolling upgrades was broken when iscsi_target table was dropped on /review. openstack. org/268320
https:/
We cannot stop using a table and drop it in the same release for rolling
upgrades to work, we have to stop using it in one release and then drop
it in the next or in the post rolling upgrade mechanism (which is still
not in place).
So this patch fixes this by removing the dropping and adding another
migration that ensure that the table is really there. That way we can
be sure that anyone using M will have the table, which then will get
dropped in N.
Closes-Bug: #1553079 745a25161d97d33 426fdd52576
Change-Id: I26586549485a8d