cached image volume not deleted if clone volume fails

[Matan Sabag]

Hi,

When creating a volume from image a new, cinder looks in the cache for a relevant cache-entry.
In case of a "hit", it calls the driver's create_cloned_volume() method.

But, when create_cloned_volume() fails, it just creates a new cache entry, instead of also deleting the old entry with the pertinent volume.

[Bharath kumar (bharath-kumar3)]

https://review.openstack.org/#/c/291204/1

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Eric Harney (<email address hidden>) on branch: master
Review: https://review.openstack.org/291204
Reason: Merge conflict since April

[zhuangzejian (zhuangzejian)]

Hi guys,
       How does this bug reproduce?
       In cinder.volume.manager.py, when we are creating the image_volume cache, we will call create volume which would call the _create_from_source_volume method where the driver's create_cloned_volume method is.
       What reference above is a par of code in cinder.volume.manager.py:

       VolumeManager._create_image_cache_volume_entry:
       try:
       ...
            image_volume = self._clone_image_volume(ctx,
                                                    volume_ref,
                                                    image_meta)
            if not image_volume:
                LOG.warning('Unable to clone image_volume for image '
                            '%(image_id)s will not create cache entry.',
                            {'image_id': image_id})
                return

            self.image_volume_cache.create_cache_entry(
                ctx,
                image_volume,
                image_id,
                image_meta
            )
        except exception.CinderException as e:
            LOG.warning('Failed to create new image-volume cache entry.'
                        ' Error: %(exception)s', {'exception': e})
            if image_volume:
                self.delete_volume(ctx, image_volume)

       If the driver's clone method failed, the image_volume would be deleted and return none. So it won't call create_cache_entry method anyway.
       I don't think the new entry(entry for image volume as a image_volume_cache) would be created if the image volume is useless(also like the driver's create_cloned_volume method failed).

[Vishakha Agarwal (vishakha.agarwal)]

Hi zhuangzejian,

VolumeManager._create_image_cache_volume_entry:

It is called only for the first time when a new cache entry is to be done. Otherwise from self._prepare_image_cache_entry in create_volume.py it does not go into its else part if already cache entry exists.

[Vishakha Agarwal (vishakha.agarwal)]

https://review.openstack.org/#/c/567473/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/567473
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a74f7f0cd00619a775483f66f134ca8952eca7d3
Submitter: Zuul
Branch: master

commit a74f7f0cd00619a775483f66f134ca8952eca7d3
Author: Vishakha Agarwal <email address hidden>
Date: Thu May 10 11:14:40 2018 +0530

    Cloning image fails results duplicate cache entry

    When creating a volume with image whose cache
    entry is already present,results in duplicate
    cache entry when create_clone_image() fails.

    Closes-Bug: #1552734
    Change-Id: I0708c333fa94bb44e66f64b2b7cc3bc0dbe8a409

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/592736

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/592736
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=93bde2210f64421d0915de107bdc2d53de94a973
Submitter: Zuul
Branch: stable/queens

commit 93bde2210f64421d0915de107bdc2d53de94a973
Author: Vishakha Agarwal <email address hidden>
Date: Thu May 10 11:14:40 2018 +0530

    Cloning image fails results duplicate cache entry

    When creating a volume with image whose cache
    entry is already present,results in duplicate
    cache entry when create_clone_image() fails.

    Closes-Bug: #1552734
    Change-Id: I0708c333fa94bb44e66f64b2b7cc3bc0dbe8a409
    (cherry picked from commit a74f7f0cd00619a775483f66f134ca8952eca7d3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.4 release.