Nested quota code considers domain to be parent

Bug #1551911 reported by Ryan McNair on 2016-03-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
High
Ryan McNair

Bug Description

The Keystone change Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55 sets the domain_id as the top-level parent project. However, this domain "parent" should not be considered in the nested quota code.

To see the issue, enable nested quotas with the latest Keystone changes and try to do a quota-show on a top-level project using the default quotas. Incorrectly, the response is all zeros.

[vagrant@vagrant cinder(keystone_admin)]$ openstack project show c9d31cc2191e40898e5adc49c691ded7
+-------------+----------------------------------+
| Field | Value |
+-------------+----------------------------------+
| description | |
| domain_id | default |
| enabled | True |
| id | c9d31cc2191e40898e5adc49c691ded7 |
| is_domain | False |
| name | A |
| parent_id | default |
+-------------+----------------------------------+

[vagrant@vagrant cinder(keystone_admin)]$ cinder quota-show c9d31cc2191e40898e5adc49c691ded7
+-----------------------+-------+
| Property | Value |
+-----------------------+-------+
| backup_gigabytes | 0 |
| backups | 0 |
| gigabytes | 0 |
| gigabytes_lvmdriver-1 | 0 |
| per_volume_gigabytes | 0 |
| snapshots | 0 |
| snapshots_lvmdriver-1 | 0 |
| volumes | 0 |
| volumes_lvmdriver-1 | 0 |
+-----------------------+-------+

Ryan McNair (rdmcnair) on 2016-03-01
Changed in cinder:
assignee: nobody → Ryan McNair (rdmcnair)
Changed in cinder:
status: New → In Progress
Jay Bryant (jsbryant) on 2016-03-01
Changed in cinder:
importance: Undecided → High
milestone: none → mitaka-3

Reviewed: https://review.openstack.org/286775
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=46bb7fe773724aff16ac8f1ec26bea788359d2cc
Submitter: Jenkins
Branch: master

commit 46bb7fe773724aff16ac8f1ec26bea788359d2cc
Author: Ryan McNair <email address hidden>
Date: Tue Mar 1 18:54:37 2016 +0000

    Update quotas to handle domain acting as project

    The Keystone change Ib22a0f3007cb7ef6b4df6f48da5f4d018e905f55 sets
    the domain_id as the top-level parent project. However, since a
    domain is not a project and therefore has no effect on quota nesting,
    the domain "parent" should not be considered in the nested quota code.
    This patch updates the quota code to ignore the domain_id if it's
    present in the parent tree.

    Change-Id: I221cfc14b886ea9819e065d4c79e8c4bfc94df45
    Closes-Bug: #1551911

Changed in cinder:
status: In Progress → Fix Released

This issue was fixed in the openstack/cinder 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers