Cinder

Bootable filter patch should use microversions

Bug #1551535 reported by Sheel Rana on 2016-03-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	High	Sheel Rana

Bug Description

We need better fix for bootable filter(refer https://bugs.launchpad.net/cinder/+bug/1535749.) But that changes API behavior.
So, this bug is created to support micro version of https://bugs.launchpad.net/cinder/+bug/1535749.

Refer below details for having insight of changes:

*Before fixing https://bugs.launchpad.net/cinder/+bug/1535749:*

Cinder treats all values passed to it as True for bootable filter in volume GET call.
For ex, if bootable=invalid, it converts it into True being
bootable as boolean value in db table 'volume'.

*After fixing https://bugs.launchpad.net/cinder/+bug/1535749:*

Filter functionality in cinder was updated to treat 'True' and 'False' values separately.
Existing behavior will be kept same.
Only True/False/true/false input handling is done such that if False/false is passed, it should treat this false and not true.
(But whatever input other than false/False/0 is passed for Boolean parameter, cinder converts it to True)

*After this microversion related fix*

Now only true/True/0/1/False/false parameters are supported.
All other input parameters will lead to raising exception.
This changes API behavior. So, kept under micro version.

Sheel Rana (ranasheel2000) on 2016-03-01

Changed in cinder:
importance:	Undecided → High
assignee:	nobody → Sheel Rana (ranasheel2000)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-23: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/278605
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0b6c68a8c1217dea32f3d03d0c3334c3b1168436
Submitter: Jenkins
Branch: master

commit 0b6c68a8c1217dea32f3d03d0c3334c3b1168436
Author: Sheel Rana <email address hidden>
Date: Tue Apr 5 23:56:55 2016 +0530

Microversion of Bootable filter in cinder list

    Currently cinder treats all non zero values passed to it
    as True for bootable filter in volume GET call.
    For ex, if bootable=invalid, it converts it into True being
    bootable as boolean value in db table 'volume'.

    Need to update filtering functionality in cinder to address
    'True' and 'False' values separately and raise exception if
    anything than True/False/true/false/0/1 is passed in this filter.

But as this will change the API behavior, microversioning is done
for this fix.

Closes-Bug: #1551535

Change-Id: Idd57014c1504eb4fc9ea0eabe894d2000ea9c364