"found extension EntryPoint.parse" blows up the size of the console log in py27 runs

Bug #1551325 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Matt Riedemann
Nominated for Liberty by Matt Riedemann

Bug Description

Seen here:

http://logs.openstack.org/periodic-stable/periodic-cinder-python27-liberty/c36b836/console.html#_2016-02-28_06_09_35_759

For things like this:

found extension EntryPoint.parse('pika = oslo_messaging._drivers.impl_pika:PikaDriver')

In that one run alone there are 67525 hits on just "found extension for EntryPoint.parse". The console logs are indexed for each job run so this is pretty bad for our logstash/elasticsearch cluster to have to deal with, not to mention simply opening that file in a browser.

We should make this less verbose since it's just debug info.

Changed in cinder:
importance: Undecided → Critical
importance: Critical → Medium
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
Matt Riedemann (mriedem) wrote :

Hmm, oslo.log already sets stevedore=WARN as the default log level:

https://github.com/openstack/oslo.log/blob/3.2.0/oslo_log/_options.py#L27

So unless something is overwriting that, I'm not sure why it'd be showing up in the cinder logs.

tags: added: logging
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cinder (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/286174

Changed in cinder:
assignee: John Griffith (john-griffith) → Matt Riedemann (mriedem)
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/286174
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=32719d4041fd547a41673539c62e5b76704c8cf8
Submitter: Jenkins
Branch: master

commit 32719d4041fd547a41673539c62e5b76704c8cf8
Author: Matt Riedemann <email address hidden>
Date: Mon Feb 29 12:31:22 2016 -0500

    Copy StandardLogging fixture from Nova

    This code was originally written for Nova by Joe Gordon
    <email address hidden> and Sean Dague <email address hidden>.

    This enables debug logging that is exercised by unit test
    runs to be handled and detect formatting errors. The debug
    logging does not actually go to the console unless the
    OS_DEBUG environment variable is set.

    As a result, a few formatting errors are detected and
    cleaned up with this change.

    This also fixes a problem where debug logging from stevedore
    is dumped to the console every time an extension is loaded,
    which in a gate-cinder-python27 job is 65K+ times.

    Change-Id: I989f9d591d1483a56a1bab3c20de583e85997562
    Closes-Bug: #1551325

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to cinder (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/286635

Matt Riedemann (mriedem)
tags: removed: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/286677

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cinder (master)

Reviewed: https://review.openstack.org/286635
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0cfe6707cf02bab74741433dbe7a91b8c5c57f38
Submitter: Jenkins
Branch: master

commit 0cfe6707cf02bab74741433dbe7a91b8c5c57f38
Author: Matt Riedemann <email address hidden>
Date: Tue Mar 1 09:44:22 2016 -0500

    Copy unit tests for StandardLogging fixture from Nova

    This comes from commit f96ec4411ce89606cf52211061003c14306dcfa1
    in Nova by Sean Dague <email address hidden>.

    The StandardLogging fixture was already merged into Cinder,
    this adds the unit tests that were missed when copying over
    the fixture.

    Change-Id: I2fbe25ec71138e4b96ff175af72a2a56c1c8f52a
    Related-Bug: #1551325

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 8.0.0.0b3

This issue was fixed in the openstack/cinder 8.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/liberty)

Reviewed: https://review.openstack.org/286677
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0d2c9038c39b61848929a8bb55d418a96afdd828
Submitter: Jenkins
Branch: stable/liberty

commit 0d2c9038c39b61848929a8bb55d418a96afdd828
Author: Matt Riedemann <email address hidden>
Date: Mon Feb 29 12:31:22 2016 -0500

    Copy StandardLogging fixture from Nova

    This code was originally written for Nova by Joe Gordon
    <email address hidden> and Sean Dague <email address hidden>.

    This enables debug logging that is exercised by unit test
    runs to be handled and detect formatting errors. The debug
    logging does not actually go to the console unless the
    OS_DEBUG environment variable is set.

    As a result, a few formatting errors are detected and
    cleaned up with this change.

    This also fixes a problem where debug logging from stevedore
    is dumped to the console every time an extension is loaded,
    which in a gate-cinder-python27 job is 65K+ times.

    Conflicts:
            cinder/tests/unit/test_vmware_vmdk.py
            cinder/volume/drivers/hpe/hpe_lefthand_iscsi.py

    NOTE(mriedem): The test_vmware_vmdk change was not needed
    in stable/liberty. The hpe_lefthand_iscsi module did not
    exist in liberty.

    Closes-Bug: #1551325
    (cherry picked from commit 32719d4041fd547a41673539c62e5b76704c8cf8)

    -- squashed with the change that adds the unit tests --

    Copy unit tests for StandardLogging fixture from Nova

    This comes from commit f96ec4411ce89606cf52211061003c14306dcfa1
    in Nova by Sean Dague <email address hidden>.

    The StandardLogging fixture was already merged into Cinder,
    this adds the unit tests that were missed when copying over
    the fixture.

    Change-Id: I2fbe25ec71138e4b96ff175af72a2a56c1c8f52a
    Related-Bug: #1551325
    (cherry picked from commit 0cfe6707cf02bab74741433dbe7a91b8c5c57f38)

    --

    Change-Id: I989f9d591d1483a56a1bab3c20de583e85997562

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 7.0.2

This issue was fixed in the openstack/cinder 7.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/cinder 7.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.