api_version_request.matches does not accept a string or None

[Scott DAngelo]

According to the Cinder devref (https://github.com/openstack/cinder/blob/master/doc/source/devref/api_microversion_dev.rst)
you should be able to use the following pattern:

def index(self, req):
    <common code>

    req_version = req.api_version_request
    if req_version.matches("3.1", "3.5"):
        ....stuff....
    elif req_version.matches("3.6", "3.10"):
        ....other stuff....
    elif req_version > api_version_request.APIVersionRequest("3.10"):
        ....more stuff.....

    <common code>

However, the api_version_request.matches() function will not accept a string, it requires an api_version_request object.

Fix this to accept a string.

[Scott DAngelo (scott-dangelo)]

I don't see this pattern used in Manila or Nova, but it won't work without a fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/285409

[Scott DAngelo (scott-dangelo)]

I've unit tests in the Cinder patch that use ddt:
https://review.openstack.org/#/c/285293

But for some reason the ddt.unpack does not work in Nova. I'll work on fixing this at some point.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/285426

[Scott DAngelo (scott-dangelo)]

Fix was proposed to Cinder, but it did not show up in Launchpad:
https://review.openstack.org/#/c/285293/4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/287194

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/287202

[OpenStack Infra (hudson-openstack)]

Change abandoned by Scott DAngelo (<email address hidden>) on branch: master
Review: https://review.openstack.org/287194
Reason: I failed to re-use the commit ID. This is replaced with https://review.openstack.org/#/c/287202/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/287202
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3f046e209ffd5729b73dd97a91a5b6cbcdc47ecb
Submitter: Jenkins
Branch: master

commit 3f046e209ffd5729b73dd97a91a5b6cbcdc47ecb
Author: scottda <email address hidden>
Date: Wed Mar 2 06:55:39 2016 -0700

    Api_version_request.matches does not accept a string or None

    According to the Cinder devref:
    https://github.com/openstack/cinder/blob/master/doc/source/devref/api_microversion_dev.rst)
    you should be able to use the following pattern:

    def index(self, req):
    <common code>

    req_version = req.api_version_request
    if req_version.matches("3.1", "3.5"):
        ....stuff....
    elif req_version.matches("3.6", "3.10"):
        ....other stuff....
    elif req_version > api_version_request.APIVersionRequest("3.10"):
        ....more stuff.....

    <common code>

    However, the api_version_request.matches() function will not accept a
    string, it requires an api_version_request object.
    This changes the doc to implement an api_version_request object to use
    this pattern.

    Closes-Bug: #1550337
    Change-Id: I14a943b21e9e98dd848c0c292ca1a1ae941cb98b

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Scott DAngelo (<email address hidden>) on branch: master
Review: https://review.openstack.org/285409
Reason: Replaced with: https://review.openstack.org/287202 which has merged.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/285293
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=72876024648052b25aac036add8c5feb2440e10f
Submitter: Jenkins
Branch: master

commit 72876024648052b25aac036add8c5feb2440e10f
Author: scottda <email address hidden>
Date: Fri Feb 26 06:17:08 2016 -0700

    Allow api_version_request.matches to accept a string

    According to the Cinder devref you should be able to use the following
    pattern:

        if req_version.matches("3.1", "3.5"):
            ....stuff....
        elif req_version.matches("3.6", "3.10"):
            ....other stuff....
        elif req_version > api_version_request.APIVersionRequest("3.10"):
            ....more stuff.....

    However, the api_version_request.matches() function will not accept a
    string, it requires an api_version_request object.

    Fix this to accept a string, as well as None for object.

    Closes-Bug: 1550337
    Change-Id: Ic90f4a13cfad601a181fd3a91684ecbb2b2fba74

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 8.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/285426
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=29b8358ef56160b2845d6ce6f5fd46695617bf7e
Submitter: Zuul
Branch: master

commit 29b8358ef56160b2845d6ce6f5fd46695617bf7e
Author: scottda <email address hidden>
Date: Fri Feb 26 09:49:28 2016 -0700

    Allow api_version_request.matches to accept a string or None

    According to the Manila devref you should be able to use the following
    pattern:

    if req_version.matches("2.1", "2.5"):
        ....stuff....
    elif req_version.matches("2.6", "2.10"):
        ....other stuff....
    elif req_version > api_version_request.APIVersionRequest("2.10"):
        ....more stuff.....

    However, the api_version_request.matches() function will not accept a
    string, it requires an api_version_request object.

    Fix this to accept a string, as well as None for object.

    Change-Id: Ic2faaaa7696cc7a647679cbb7a8600b30c3d66d7
    Closes-Bug: 1550337

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/577806

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/577806
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=93b48681a341ce674bbae6f7784d92db05d5da5b
Submitter: Zuul
Branch: stable/queens

commit 93b48681a341ce674bbae6f7784d92db05d5da5b
Author: scottda <email address hidden>
Date: Fri Feb 26 09:49:28 2016 -0700

    Allow api_version_request.matches to accept a string or None

    According to the Manila devref you should be able to use the following
    pattern:

    if req_version.matches("2.1", "2.5"):
        ....stuff....
    elif req_version.matches("2.6", "2.10"):
        ....other stuff....
    elif req_version > api_version_request.APIVersionRequest("2.10"):
        ....more stuff.....

    However, the api_version_request.matches() function will not accept a
    string, it requires an api_version_request object.

    Fix this to accept a string, as well as None for object.

    Change-Id: Ic2faaaa7696cc7a647679cbb7a8600b30c3d66d7
    Closes-Bug: 1550337
    (cherry picked from commit 29b8358ef56160b2845d6ce6f5fd46695617bf7e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 7.0.0.0b3 development milestone.