No need to raise exc.HTTPBadRequest when no volume_id in create_backup

[Lisa Li]

Mitaka imports the function of backing snapshot.

When creating backup of a snapshot with following comamnd:
curl -g -i -X POST http://192.168.2.180:8776/v2/2add7d16f22a45a789ab896805e3bdc4/backups -H "User-Agent: python-cinderclient" -H "Content-Type: application/json" -H "Accept: application/json" -H "X-Auth-Token: 4d52d927501745318d578814cd61cc88" -d '{"backup": {"force": false, "description": null, "incremental": false, "snapshot_id": "3d12f820-853d-406d-920f-01399c94426a", "container": null, "name": "test1"}}'

it gives following error:

HTTP/1.1 400 Bad Request
Content-Length: 73
Content-Type: application/json; charset=UTF-8
X-Compute-Request-Id: req-843344e9-1e52-4c4c-af77-00e00fbc3fff
X-Openstack-Request-Id: req-843344e9-1e52-4c4c-af77-00e00fbc3fff
Date: Thu, 25 Feb 2016 07:37:54 GMT

{"badRequest": {"message": "Incorrect request body format", "code": 400}}

Reason:

    def create(self, req, body):
        """Create a new backup."""
        LOG.debug('Creating new backup %s', body)
        self.assert_valid_body(body, 'backup')

        context = req.environ['cinder.context']
        backup = body['backup']

        try:
            volume_id = backup['volume_id']
        except KeyError:
            msg = _("Incorrect request body format")
            raise exc.HTTPBadRequest(explanation=msg) Here no need to raise exception.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/284572

[Lisa Li (lisali)]

Set it to low as volume_id in creating backup is required in Liberty. Should/Can we change it from required to optional when introducing snapshot backup?

[OpenStack Infra (hudson-openstack)]

Change abandoned by LisaLi (<email address hidden>) on branch: master
Review: https://review.openstack.org/284572

[Sean McGinnis (sean-mcginnis)]

Unassigning due to no activity for > 6 months.