Zfssaiscsi driver should not use 'default' initiator group

[OpenStack Infra]

https://review.openstack.org/238635
Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
Your project "openstack/cinder" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

commit c035c41142625a2a25add7b0580d038a0ee562b7
Author: Abhiram Moturi <email address hidden>
Date: Thu Oct 22 17:28:26 2015 +0000

    Zfssaiscsi driver should not use 'default' initiator group

    The zfssaiscsi driver falls back to using the 'default'
    initiator group when it fails to find a valid initiator group
    configured. This causes all LUNs attached to instances on that
    server to be presented to every server using the target group.

    This fix makes the driver use the 'default' group only if
    configured in the cinder.conf file. It also throws an error when
    initiator group is given without any initiators.

    DocImpact
    Change-Id: I417688cf632baa727e5aa339c8d362761a38dcc8
    Closes-Bug: #1508548

[Sean McGinnis (sean-mcginnis)]

Please add notes as to what the documentation impact is for this change. The bug can then be assigned to the openstack-manuals project.

[abhiram moturi (abhiram-moturi)]

Change for the doc needs to be made in - http://docs.openstack.org/liberty/config-reference/content/zfssa-iscsi-driver.html
A note should be added that to use 'default' initiator group, the parameter zfssa_initiator_group should be explicitly set to 'default'

[Matt Kassawara (ionosphere80)]

The point of creating bugs in a project's repository for patches containing DocImpact is to enable projects to track documentation patches, not throw them over the fence at the documentation team.

[Sean McGinnis (sean-mcginnis)]

Matt, per the mailing list thread on this, we were told the process was to have them opened against the project so we would have an opportunity to add necessary information to so the docs team would no longer need to guess what was needed. For those bugs that had all of the information in the commit message I have switched them over since there is nothing else to add.

If we are saying we no longer care about documentation, then I will resurrect that thread and propose we change back to the old way, as this is pointless and just a distraction otherwise.

[Jay Bryant (jsbryant)]

Working on cleaning up bugs. This has been around for a long time. Can re-open if it is still needed.