Cinder

get_replication_updates in manager.py does NOTHING

Bug #1547666 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
John Griffith

Bug Description

manager.py has a call "driver.get_replication_update" as part of the _report_driver_status periodic. This call does nothing. Even if something is returned from the driver, the manager doesn't do anything with it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/282537

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/282537
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2ed92b09d53efb252afef59c4f453b4f836d5968
Submitter: Jenkins
Branch: master

commit 2ed92b09d53efb252afef59c4f453b4f836d5968
Author: John Griffith <email address hidden>
Date: Fri Feb 19 14:16:54 2016 -0700

    Remove useless get_replication_updates driver call

    We had the call in the manager as part of a periodic,
    it did nothing at all. Some drivers had comments "no idea
    what to do with this", even better we had unit tests that
    faked out a call that returned nothing and asserted it was
    nothing. ?!?

    Let's just remove it

    Change-Id: I3c1ef6065e73d90912d7f765d581add9bc704c7b
    Closes-Bug: #1547666

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 8.0.0.0b3

This issue was fixed in the openstack/cinder 8.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.