When stopping services Cinder doesn't wait for periodic tasks

Bug #1546234 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Gorka Eguileor

Bug Description

When a Service in cinder stops we stop the periodic tasks but then we don't wait for them to properly stop.

wait method in Service class should be waiting for the FixedIntervalLoopingCall tasks to stop before exiting.

Gorka Eguileor (gorka)
Changed in cinder:
assignee: nobody → Gorka Eguileor (gorka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280873

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/280873
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=598e35c337c6acf0f7558a874e85c727fc0fbde2
Submitter: Jenkins
Branch: master

commit 598e35c337c6acf0f7558a874e85c727fc0fbde2
Author: Gorka Eguileor <email address hidden>
Date: Tue Feb 16 19:03:49 2016 +0100

    Wait for periodic tasks to stop on exit

    When a Service in Cinder exits it stops all operations and waits for
    them to complete, and it also stops all periodica tasks created with
    FixedIntervalLoop, but it doesn't wait until these are completed.

    This patch will wait for all periodic tasks that received the stop
    request without raising an exception before exiting.

    Change-Id: I984b8aebd40f9482f0cf8098146d1ccd635dc1d6
    Closes-Bug: #1546234

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 8.0.0.0b3

This issue was fixed in the openstack/cinder 8.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.