CONF.volume_api_class doesnt have any effect

Bug #1543219 reported by Cory Stone
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Cory Stone

Bug Description

CONF.volume_api_class isn't evaluated correctly in cinder/volume/__init__.py

CONF() has not been called yet, so this is always the default value instead of the value specified in the config file.

Cory Stone (corystone)
Changed in cinder:
assignee: nobody → Cory Stone (corystone)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/277504

Changed in cinder:
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/277504
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=010d4a23b7f25cfa9786cecc35939f667a6812ba
Submitter: Jenkins
Branch: master

commit 010d4a23b7f25cfa9786cecc35939f667a6812ba
Author: Cory Stone <email address hidden>
Date: Mon Feb 8 11:22:59 2016 -0600

    Fix dynamic import of CONF.volume_api_class

    Modifies the import to actually happen when API() is called instead of
    when the module is loaded.

    This is necessary because CONF.volume_api_class is always evaluated as
    the default value since the config file hadn't been parsed yet when the
    module is loaded.

    Nova fixed this problem a while ago for the compute driver in
    https://review.openstack.org/#/c/14353/.

    Change-Id: I4c3d6b4300298ad0ac4e40a7a1a815cbf88bb151
    Closes-Bug: #1543219

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/280297

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/liberty)

Reviewed: https://review.openstack.org/280297
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1cbf08aa9543da0d45b6bdeb7814ec01ffd84c72
Submitter: Jenkins
Branch: stable/liberty

commit 1cbf08aa9543da0d45b6bdeb7814ec01ffd84c72
Author: Cory Stone <email address hidden>
Date: Mon Feb 8 11:22:59 2016 -0600

    Fix dynamic import of CONF.volume_api_class

    Modifies the import to actually happen when API() is called instead of
    when the module is loaded.

    This is necessary because CONF.volume_api_class is always evaluated as
    the default value since the config file hadn't been parsed yet when the
    module is loaded.

    Nova fixed this problem a while ago for the compute driver in
    https://review.openstack.org/#/c/14353/.

    Conflicts:
     cinder/tests/unit/api/contrib/test_volume_actions.py
     cinder/tests/unit/api/contrib/test_volume_host_attribute.py
     cinder/tests/unit/api/contrib/test_volume_image_metadata.py
     cinder/tests/unit/api/contrib/test_volume_migration_status_attribute.py
     cinder/tests/unit/api/v1/test_snapshot_metadata.py
     cinder/tests/unit/api/v1/test_volume_metadata.py
     cinder/tests/unit/api/v2/test_snapshot_metadata.py
     cinder/tests/unit/api/v2/test_volume_metadata.py

    Change-Id: I4c3d6b4300298ad0ac4e40a7a1a815cbf88bb151
    Closes-Bug: #1543219
    (cherry picked from commit 010d4a23b7f25cfa9786cecc35939f667a6812ba)

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 8.0.0.0b3

This issue was fixed in the openstack/cinder 8.0.0.0b3 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 7.0.2

This issue was fixed in the openstack/cinder 7.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/cinder 7.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.