Cinder

InstanceLocalityFilter doesn't work

Bug #1517431 reported by Ivan Kolodyazhny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Ivan Kolodyazhny
Cinder mitaka-1 "m1"

Bug Description

Condition [1] will be always true and CinderException will be raised. The root cause is here [2]: we check for client-side extensions instead of server-side one

[1] https://github.com/openstack/cinder/blob/master/cinder/scheduler/filters/instance_locality_filter.py#L96
[2] https://github.com/openstack/cinder/blob/master/cinder/compute/nova.py#L161

Ivan Kolodyazhny (e0ne)
Changed in cinder:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Ivan Kolodyazhny (e0ne)
tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/246932

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/246933

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/246932
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=48ca2ca67c63cc57965f339bb45999222b4fc771
Submitter: Jenkins
Branch: master

commit 48ca2ca67c63cc57965f339bb45999222b4fc771
Author: Ivan Kolodyazhny <email address hidden>
Date: Wed Nov 18 15:42:13 2015 +0200

    Fix InstanceLocalityFilter scheduler filter

    Commit I51254e20151fe1d6771897e64a8d0bdf2d674d03 introduces new error:
    We use novaclient extensions instead of Nova API extensions. In such
    case, InstanceLocalityFilter won't find Nova ExtendedServerAttributes
    extension and will raise CinderException.

    This patch fixes novaclient usage in a right way.

    Change-Id: I36fb67d597b7848dd4796ea672bc573a570677e8
    Closes-Bug: #1517431

Changed in cinder:
status: In Progress → Fix Committed
Ivan Kolodyazhny (e0ne)
Changed in cinder:
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/liberty)

Reviewed: https://review.openstack.org/246933
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=8c463f1650b85781e42909283332655d8e7fdcb9
Submitter: Jenkins
Branch: stable/liberty

commit 8c463f1650b85781e42909283332655d8e7fdcb9
Author: Ivan Kolodyazhny <email address hidden>
Date: Wed Nov 18 15:42:13 2015 +0200

    Fix InstanceLocalityFilter scheduler filter

    Commit I51254e20151fe1d6771897e64a8d0bdf2d674d03 introduces new error:
    We use novaclient extensions instead of Nova API extensions. In such
    case, InstanceLocalityFilter won't find Nova ExtendedServerAttributes
    extension and will raise CinderException.

    This patch fixes novaclient usage in a right way.

    Change-Id: I36fb67d597b7848dd4796ea672bc573a570677e8
    Closes-Bug: #1517431
    (cherry-picked from commit I36fb67d597b7848dd4796ea672bc573a570677e8)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b1

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in cinder 7.0.1

This issue was fixed in the cinder 7.0.1 release (liberty).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.