Use oslo_config new type PortOpt for port options

Bug #1514702 reported by chenying
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
chenying

Bug Description

The oslo_config library provides new type PortOpt to validate the
range of port now. We can replace them with PortOpt.

The PortOpt type only supports 1-65535, so if the option needs to support port 0

(which means anything available) then it can only be IntOpt.

https://github.com/openstack/cinder/blob/master/cinder/service.py#L65

    cfg.StrOpt('osapi_volume_listen',
               default="0.0.0.0",
               help='IP address on which OpenStack Volume API listens'),
    cfg.IntOpt('osapi_volume_listen_port',
               default=8776,
               min=1, max=65535,
               help='Port on which OpenStack Volume API listens'),
    cfg.IntOpt('osapi_volume_workers',
               help='Number of workers for OpenStack Volume API service. '
                    'The default is equal to the number of CPUs available.'), ]

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243433

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/243433
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=7ef20e1b910498e5a7952ec373286e69485a8533
Submitter: Jenkins
Branch: master

commit 7ef20e1b910498e5a7952ec373286e69485a8533
Author: chenying <email address hidden>
Date: Tue Nov 10 15:17:57 2015 +0800

    Use oslo_config new type PortOpt for port options

    The oslo_config library provides new type PortOpt to validate the
    range of port now.
    ref: https://github.com/openstack/oslo.config/blob/2.6.0/oslo_config/cfg.py#L1114

    DocImpact
    Change-Id: I9a3e4d13feef67b4a43936c6099b822e4f1f6a57
    Closes-Bug: #1514702

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/cinder 8.0.0.0b1

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.