Test nova timeout failing on master

[Nate Potter]

Currently on master running the test cinder.tests.unit.scheduler.test_host_filters.InstanceLocalityFilterTestCase.test_nova_timeout fails with the following traceback:

http://paste.openstack.org/show/477492/

I'm noticing this both on my local machine as well as in Gerrit, when I pushed up this patch: https://review.openstack.org/#/c/239704/. The report of the failure is here http://logs.openstack.org/04/239704/1/check/gate-cinder-python27/7f943f5/console.html.

[Matt Riedemann (mriedem)]

It's due to something in novaclient 2.33 released on 10/27.

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22b'novaclient.exceptions.RequestTimeout:%20Request%20Timeout%20(HTTP%20)'%5C%22%20AND%20build_name:%5C%22gate-cinder-python34%5C%22%20AND%20tags:%5C%22console%5C%22

28 hits in 24 hours, check and gate, all failures.

[Matt Riedemann (mriedem)]

This is the novaclient change that went into 2.33 that would have probably triggered this on the cinder unit test side:

https://review.openstack.org/#/c/235558/

[Matt Riedemann (mriedem)]

The cinder unit test is expecting a requests.exceptions.Timeout but it got novaclient.exceptions.RequestTimeout because novaclient is handling the requests exceptions now and converting them to it's own exceptions. So the cinder test just needs to account for both.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/239941

[Matt Riedemann (mriedem)]

https://review.openstack.org/#/c/239837/ was a cinder change that was fast approved this morning under a different bug, it adds the handling to cinder for both exceptions.