unmanage volume/snapshot reduce quota incorrectly

Bug #1504007 reported by wanghao
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
wanghao

Bug Description

When managing volume/snapshot get error, the quota usage will roll back and set the new volume/snapshot status to error, but then delete/unmanage this resource, quota usage will be reduced again, it's incorrect.

Test steps:
1.Check the quota usage of current tenant.
2.Manage a volume which is not exist, and the new volume will be error.
3.Check the quota usage of current tenant, it will be not changed.
4.Delete/Unmanage this volume successfully, and check the quota usage again, it will be -1 again.

wanghao (wanghao749)
Changed in cinder:
assignee: nobody → wanghao (wanghao749)
wanghao (wanghao749)
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/232436

Changed in cinder:
status: New → In Progress
wanghao (wanghao749)
Changed in cinder:
importance: Undecided → Medium
tags: added: liberty-backport-potential
wanghao (wanghao749)
Changed in cinder:
milestone: none → mitaka-rc1
Changed in cinder:
milestone: mitaka-rc1 → newton-1
Changed in cinder:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/333164

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by wanghao (<email address hidden>) on branch: master
Review: https://review.openstack.org/232436
Reason: abandon this since we have new way to solve this issue: https://review.openstack.org/#/c/333164/

Changed in cinder:
milestone: newton-2 → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/333164
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=efd1f5c7eb2aa1ba0765b179fe3c0e479b5f403a
Submitter: Jenkins
Branch: master

commit efd1f5c7eb2aa1ba0765b179fe3c0e479b5f403a
Author: wanghao <email address hidden>
Date: Thu Jun 23 16:04:35 2016 +0800

    Refactor volume status in managing vol

    This feature introduce 'managing' and 'error_managing'
    status into managing process and 'error_managing_deleting'
    status into deleting processto to fix the quota decrease
    issue when some exception is raised in c-vol. If volume is
    in error_managing, quota wouldn't be decreased
    when deleting this volume. But we still expose
    'creating','error' and 'deleting' status to user for API
    compatibility.

    Change-Id: I5887c5f2ded6d6a18f497a018d5bf6105bc5afd7
    Closes-Bug: #1504007
    Implements: blueprint refactor-volume-status-in-managing-vol

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 10.0.0.0b1

This issue was fixed in the openstack/cinder 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.