cinder volume transfer does not update quotas for volume types

[craig]

when you have more than default volume types and you transfer a volume type from one tenant to another it correctly updates the quota for the default values, but does not update for the volume type values.

this only seems to affect configs with multiple volume types

pre-transfer
+---------------------------+--------+----------+-------+
| Type | In_use | Reserved | Limit |
+---------------------------+--------+----------+-------+
| gigabytes | 100 | 0 | 1000 |
| gigabytes_Performance-SSD | 0 | 0 | 1000 |
| gigabytes_Standard-HDD | 100 | 0 | 1000 |
| snapshots | 0 | 0 | 10 |
| snapshots_Performance-SSD | 0 | 0 | 10 |
| snapshots_Standard-HDD | 0 | 0 | 10 |
| volumes | 1 | 0 | 10 |
| volumes_Performance-SSD | 0 | 0 | 10 |
| volumes_Standard-HDD | 1 | 0 | 10 |
+---------------------------+--------+----------+-------+

post transfer

+---------------------------+--------+----------+-------+
| Type | In_use | Reserved | Limit |
+---------------------------+--------+----------+-------+
| gigabytes | 0 | 0 | 1000 |
| gigabytes_Performance-SSD | 0 | 0 | 1000 |
| gigabytes_Standard-HDD | 100 | 0 | 1000 |
| snapshots | 0 | 0 | 10 |
| snapshots_Performance-SSD | 0 | 0 | 10 |
| snapshots_Standard-HDD | 0 | 0 | 10 |
| volumes | 0 | 0 | 10 |
| volumes_Performance-SSD | 0 | 0 | 10 |
| volumes_Standard-HDD | 1 | 0 | 10 |
+---------------------------+--------+----------+-------+

so this will cause a lot of quota issues where users are not seeing that they have something still counting against their quota.

also, when you transfer the volume back, it again just updated the defaults, so everything looks fine.

re-creation steps:
from tenant A:
1. not quota usage via cinder quota-show <tenant>
2. create new volume with a non-default volume type
3. transfer volume to tenant B
4. accept transfer on tenant B
5. check quotas

[Sean McGinnis (sean-mcginnis)]

Deepti, are you actively working on this? I was pinged by someone that is affected and would like to see this move forward. If you are not actively working on it, please remove yourself as the assignee so someone else can possibly pick it up. Thanks.

[Deepti Ramakrishna (dramakri)]

Hi Sean,

Apologizes for the delayed response. For some reason inspite of being subscribed to bug notifications, I didn't receive email for your comment. Given my priorities moved around a bit recently, I will unassign myself from this bug for now. I hope to be active on Cinder starting early next year.

Thanks,
Deepti

[Sean McGinnis (sean-mcginnis)]

Thanks Deepti!

[Mitsuhiro Tanino (mitsuhiro-tanino)]

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/245320/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/245320
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=173fd8604c5fe1237330eca96efdc356906ced50
Submitter: Jenkins
Branch: master

commit 173fd8604c5fe1237330eca96efdc356906ced50
Author: Mitsuhiro Tanino <email address hidden>
Date: Fri Nov 13 15:01:32 2015 -0500

    Fix quotas issue during volume transfer

    When admin transfers a volume with volume type from
    one tenant to another, it correctly updates the quota
    for the default values, but does not update for the
    volume type values.

    This patch fixes the problem to update quotas for
    the volume type values.

    Change-Id: If444639cea8e74a415220df43fccfb155ca89216
    Closes-Bug: #1501855

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/251181

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/251181
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1a06292643d061a470f6433d0f0bbfe49bc49926
Submitter: Jenkins
Branch: stable/liberty

commit 1a06292643d061a470f6433d0f0bbfe49bc49926
Author: Mitsuhiro Tanino <email address hidden>
Date: Sun Nov 29 21:59:39 2015 -0500

    Fix quotas issue during volume transfer

    When admin transfers a volume with volume type from
    one tenant to another, it correctly updates the quota
    for the default values, but does not update for the
    volume type values.

    This patch fixes the problem to update quotas for
    the volume type values.

    Closes-Bug: #1501855
    (cherry picked from commit 173fd8604c5fe1237330eca96efdc356906ced50)
    Conflicts:
        cinder/tests/unit/test_volume_transfer.py

    Change-Id: If444639cea8e74a415220df43fccfb155ca89216

[Thierry Carrez (ttx)]

This issue was fixed in the cinder 7.0.1 release (liberty).